2021-09-05 07:17:13

by Saurav Girepunje

Subject: [PATCH] staging: r8188eu: include: remove duplicate declaration.

Remove below duplicate declaration from rtl8188e_led.h file

void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
index b00954198764..02cdc970bb17 100644
--- a/drivers/staging/r8188eu/include/rtl8188e_led.h
+++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
@@ -12,7 +12,5 @@
/* */
void rtl8188eu_InitSwLeds(struct adapter *padapter);
void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
-void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
-void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);

#endif
--
2.32.0

2021-09-06 10:45:11

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: r8188eu: include: remove duplicate declaration.

On Sun, Sep 05, 2021 at 12:44:37PM +0530, Saurav Girepunje wrote:
> Remove below duplicate declaration from rtl8188e_led.h file
>
> void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
> drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
> index b00954198764..02cdc970bb17 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_led.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
> @@ -12,7 +12,5 @@
> /* */
> void rtl8188eu_InitSwLeds(struct adapter *padapter);
> void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
> -void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> -void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
>
> #endif
> --
> 2.32.0
>

This email did not make it to lore.kernel.org again:
https://lore.kernel.org/r/YTRuXTu/kePBDwAF@user

Any ideas what is happening?

thanks,

greg k-h

2021-09-06 16:35:37

by Saurav Girepunje

Subject: Re: [PATCH] staging: r8188eu: include: remove duplicate declaration.

On 06/09/21 3:18 pm, Greg KH wrote:
> On Sun, Sep 05, 2021 at 12:44:37PM +0530, Saurav Girepunje wrote:
>> Remove below duplicate declaration from rtl8188e_led.h file
>>
>> void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
>> void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
>>
>> Signed-off-by: Saurav Girepunje <[email protected]>
>> ---
>> drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
>> index b00954198764..02cdc970bb17 100644
>> --- a/drivers/staging/r8188eu/include/rtl8188e_led.h
>> +++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
>> @@ -12,7 +12,5 @@
>> /* */
>> void rtl8188eu_InitSwLeds(struct adapter *padapter);
>> void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
>> -void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
>> -void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
>>
>> #endif
>> --
>> 2.32.0
>>
>
> This email did not make it to lore.kernel.org again:
> https://lore.kernel.org/r/YTRuXTu/kePBDwAF@user
>
> Any ideas what is happening?
> [email protected]
> thanks,
>
> greg k-h
>

I missed to add the [email protected]. I will resend it v2
version of this patch.
However I am able to see it on https://lore.kernel.org .

https://lore.kernel.org/all/YTRuXTu%2FkePBDwAF@user/

Regards,
Saurav Girepunje

2021-09-07 06:31:16

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: r8188eu: include: remove duplicate declaration.

On Mon, Sep 06, 2021 at 10:04:07PM +0530, Saurav Girepunje wrote:
>
>
> On 06/09/21 3:18 pm, Greg KH wrote:
> > On Sun, Sep 05, 2021 at 12:44:37PM +0530, Saurav Girepunje wrote:
> > > Remove below duplicate declaration from rtl8188e_led.h file
> > >
> > > void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> > > void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
> > >
> > > Signed-off-by: Saurav Girepunje <[email protected]>
> > > ---
> > > drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > index b00954198764..02cdc970bb17 100644
> > > --- a/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > +++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > @@ -12,7 +12,5 @@
> > > /* */
> > > void rtl8188eu_InitSwLeds(struct adapter *padapter);
> > > void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
> > > -void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> > > -void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
> > >
> > > #endif
> > > --
> > > 2.32.0
> > >
> >
> > This email did not make it to lore.kernel.org again:
> > https://lore.kernel.org/r/YTRuXTu/kePBDwAF@user
> >
> > Any ideas what is happening?
> > [email protected]
> > thanks,
> >
> > greg k-h
> >
>
> I missed to add the [email protected]. I will resend it v2
> version of this patch.
> However I am able to see it on https://lore.kernel.org .
>
> https://lore.kernel.org/all/YTRuXTu%2FkePBDwAF@user/

Ah, your message id has a '/' character in it, that's what is breaking
the scripts...

Let me see what needs to be fixed up.

thanks,

greg k-h

2021-09-07 07:21:01

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: r8188eu: include: remove duplicate declaration.

On Mon, Sep 06, 2021 at 10:04:07PM +0530, Saurav Girepunje wrote:
>
>
> On 06/09/21 3:18 pm, Greg KH wrote:
> > On Sun, Sep 05, 2021 at 12:44:37PM +0530, Saurav Girepunje wrote:
> > > Remove below duplicate declaration from rtl8188e_led.h file
> > >
> > > void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> > > void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
> > >
> > > Signed-off-by: Saurav Girepunje <[email protected]>
> > > ---
> > > drivers/staging/r8188eu/include/rtl8188e_led.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/drivers/staging/r8188eu/include/rtl8188e_led.h b/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > index b00954198764..02cdc970bb17 100644
> > > --- a/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > +++ b/drivers/staging/r8188eu/include/rtl8188e_led.h
> > > @@ -12,7 +12,5 @@
> > > /* */
> > > void rtl8188eu_InitSwLeds(struct adapter *padapter);
> > > void rtl8188eu_DeInitSwLeds(struct adapter *padapter);
> > > -void SwLedOn(struct adapter *padapter, struct LED_871x *pLed);
> > > -void SwLedOff(struct adapter *padapter, struct LED_871x *pLed);
> > >
> > > #endif
> > > --
> > > 2.32.0
> > >
> >
> > This email did not make it to lore.kernel.org again:
> > https://lore.kernel.org/r/YTRuXTu/kePBDwAF@user
> >
> > Any ideas what is happening?
> > [email protected]
> > thanks,
> >
> > greg k-h
> >
>
> I missed to add the [email protected]. I will resend it v2
> version of this patch.
> However I am able to see it on https://lore.kernel.org .
>
> https://lore.kernel.org/all/YTRuXTu%2FkePBDwAF@user/

You are right, that is odd. I've emailed the b4 developer to see what
is up with this, I'll take this patch in a bit...

thanks,

greg k-h