2018-01-27 12:14:06

by SF Markus Elfring

Subject: [PATCH 0/2] Input: max7359_keypad: Adjustments for max7359_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 27 Jan 2018 13:08:24 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/input/keyboard/max7359_keypad.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

--
2.16.1

2018-01-27 12:15:14

by SF Markus Elfring

Subject: [PATCH 1/2] Input: max7359_keypad: Delete an error message for a failed memory allocation in max7359_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 27 Jan 2018 12:56:25 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/keyboard/max7359_keypad.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/max7359_keypad.c b/drivers/input/keyboard/max7359_keypad.c
index cd44d22d8770..ba6a670a769e 100644
--- a/drivers/input/keyboard/max7359_keypad.c
+++ b/drivers/input/keyboard/max7359_keypad.c
@@ -184,10 +184,8 @@ static int max7359_probe(struct i2c_client *client,

keypad = devm_kzalloc(&client->dev, sizeof(struct max7359_keypad),
GFP_KERNEL);
- if (!keypad) {
- dev_err(&client->dev, "failed to allocate memory\n");
+ if (!keypad)
return -ENOMEM;
- }

input_dev = devm_input_allocate_device(&client->dev);
if (!input_dev) {
--
2.16.1

2018-01-27 12:16:41

by SF Markus Elfring

Subject: [PATCH 2/2] Input: max7359_keypad: Improve a size determination in max7359_probe()

From: Markus Elfring <[email protected]>
Date: Sat, 27 Jan 2018 13:00:10 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/keyboard/max7359_keypad.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/max7359_keypad.c b/drivers/input/keyboard/max7359_keypad.c
index ba6a670a769e..7791250b4667 100644
--- a/drivers/input/keyboard/max7359_keypad.c
+++ b/drivers/input/keyboard/max7359_keypad.c
@@ -181,9 +181,7 @@ static int max7359_probe(struct i2c_client *client,
}

dev_dbg(&client->dev, "keys FIFO is 0x%02x\n", ret);
-
- keypad = devm_kzalloc(&client->dev, sizeof(struct max7359_keypad),
- GFP_KERNEL);
+ keypad = devm_kzalloc(&client->dev, sizeof(*keypad), GFP_KERNEL);
if (!keypad)
return -ENOMEM;

--
2.16.1