Hi,
On 1/27/23 21:05, Deepak R Varma wrote:
> Simplify code by using min_t helper macro for logical evaluation
> and value assignment. Use the _t variant of min macro since the
> variable types are not same.
> This issue is identified by coccicheck using the minmax.cocci file.
>
> Signed-off-by: Deepak R Varma <[email protected]>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/think-lmi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
> index a01a92769c1a..caa862506ed3 100644
> --- a/drivers/platform/x86/think-lmi.c
> +++ b/drivers/platform/x86/think-lmi.c
> @@ -317,8 +317,8 @@ static int tlmi_get_pwd_settings(struct tlmi_pwdcfg *pwdcfg)
> return -EIO;
> }
>
> - copy_size = obj->buffer.length < sizeof(struct tlmi_pwdcfg) ?
> - obj->buffer.length : sizeof(struct tlmi_pwdcfg);
> + copy_size = min_t(size_t, obj->buffer.length, sizeof(struct tlmi_pwdcfg));
> +
> memcpy(pwdcfg, obj->buffer.pointer, copy_size);
> kfree(obj);
>