2020-10-10 23:14:30

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API

On Sat, 10 Oct 2020 12:26:23 +0530 Anant Thazhemadam wrote:
> GPF_KERNEL

You haven't even built this, let alone tested :/


2020-10-11 10:12:19

by Anant Thazhemadam

[permalink] [raw]
Subject: Re: [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API


On 10/10/20 10:33 pm, Jakub Kicinski wrote:
> On Sat, 10 Oct 2020 12:26:23 +0530 Anant Thazhemadam wrote:
>> GPF_KERNEL
> You haven't even built this, let alone tested :/

I'm really sorry about this.
Turns out, my .config wasn't set generated by make allyesconfig, and thus
this regression went undetected.

I can submit a v2 that doesn't break the build, and which is build tested
properly.
However, I'm not clear on how else I could locally run unit tests pertaining to this
patch. I understand the critical requirement for testing changes and would really
appreciate it if someone could direct me towards some resource or another that
could help me figure that out too.

Once again, I'm really sorry for this oversight.
Thank you for your time.

Thanks,
Anant