2021-05-12 02:59:05

by Zou Wei

[permalink] [raw]
Subject: [PATCH -next] reset: brcmstb: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/reset/reset-brcmstb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/reset/reset-brcmstb.c b/drivers/reset/reset-brcmstb.c
index f213264..42c9d52 100644
--- a/drivers/reset/reset-brcmstb.c
+++ b/drivers/reset/reset-brcmstb.c
@@ -111,6 +111,7 @@ static const struct of_device_id brcmstb_reset_of_match[] = {
{ .compatible = "brcm,brcmstb-reset" },
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, brcmstb_reset_of_match);

static struct platform_driver brcmstb_reset_driver = {
.probe = brcmstb_reset_probe,
--
2.6.2


2021-05-12 06:10:02

by Philipp Zabel

[permalink] [raw]
Subject: Re: [PATCH -next] reset: brcmstb: Add missing MODULE_DEVICE_TABLE

On Wed, 2021-05-12 at 11:14 +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Thank you, applied to reset/next with

Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver")

added.

regards
Philipp

2021-05-12 13:51:53

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH -next] reset: brcmstb: Add missing MODULE_DEVICE_TABLE



On 5/11/2021 11:06 PM, Philipp Zabel wrote:
> On Wed, 2021-05-12 at 11:14 +0800, Zou Wei wrote:
>> This patch adds missing MODULE_DEVICE_TABLE definition which generates
>> correct modalias for automatic loading of this driver when it is built
>> as an external module.
>>
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Zou Wei <[email protected]>
>
> Thank you, applied to reset/next with
>
> Fixes: 77750bc089e4 ("reset: Add Broadcom STB SW_INIT reset controller driver")

Acked-by: Florian Fainelli <[email protected]>

And thanks for adding the Fixes: tag as well.
--
Florian