2010-06-30 15:55:08

by Christoph Egger

[permalink] [raw]
Subject: [PATCH 04/33] Removing dead MSM7X00A_IDLE

MSM7X00A_IDLE doesn't exist in Kconfig, therefore removing all
references for it from the source code.

Signed-off-by: Christoph Egger <[email protected]>
---
arch/arm/mach-msm/idle.S | 13 -------------
1 files changed, 0 insertions(+), 13 deletions(-)

diff --git a/arch/arm/mach-msm/idle.S b/arch/arm/mach-msm/idle.S
index 6a94f05..d8e8027 100644
--- a/arch/arm/mach-msm/idle.S
+++ b/arch/arm/mach-msm/idle.S
@@ -20,17 +20,4 @@
#include <asm/assembler.h>

ENTRY(arch_idle)
-#ifdef CONFIG_MSM7X00A_IDLE
- mrc p15, 0, r1, c1, c0, 0 /* read current CR */
- bic r0, r1, #(1 << 2) /* clear dcache bit */
- bic r0, r0, #(1 << 12) /* clear icache bit */
- mcr p15, 0, r0, c1, c0, 0 /* disable d/i cache */
-
- mov r0, #0 /* prepare wfi value */
- mcr p15, 0, r0, c7, c10, 0 /* flush the cache */
- mcr p15, 0, r0, c7, c10, 4 /* memory barrier */
- mcr p15, 0, r0, c7, c0, 4 /* wait for interrupt */
-
- mcr p15, 0, r1, c1, c0, 0 /* restore d/i cache */
-#endif
mov pc, lr
--
1.7.0.4


2010-06-30 19:59:35

by Kirill A. Shutemov

[permalink] [raw]
Subject: Re: [PATCH 04/33] Removing dead MSM7X00A_IDLE

On Wed, Jun 30, 2010 at 05:55:03PM +0200, Christoph Egger wrote:
> MSM7X00A_IDLE doesn't exist in Kconfig, therefore removing all
> references for it from the source code.

It was removed in commit 1637de0c9. I'm not sure if it's correct.

Brian Swetland added to CC list.

> Signed-off-by: Christoph Egger <[email protected]>
> ---
> arch/arm/mach-msm/idle.S | 13 -------------
> 1 files changed, 0 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/mach-msm/idle.S b/arch/arm/mach-msm/idle.S
> index 6a94f05..d8e8027 100644
> --- a/arch/arm/mach-msm/idle.S
> +++ b/arch/arm/mach-msm/idle.S
> @@ -20,17 +20,4 @@
> #include <asm/assembler.h>
>
> ENTRY(arch_idle)
> -#ifdef CONFIG_MSM7X00A_IDLE
> - mrc p15, 0, r1, c1, c0, 0 /* read current CR */
> - bic r0, r1, #(1 << 2) /* clear dcache bit */
> - bic r0, r0, #(1 << 12) /* clear icache bit */
> - mcr p15, 0, r0, c1, c0, 0 /* disable d/i cache */
> -
> - mov r0, #0 /* prepare wfi value */
> - mcr p15, 0, r0, c7, c10, 0 /* flush the cache */
> - mcr p15, 0, r0, c7, c10, 4 /* memory barrier */
> - mcr p15, 0, r0, c7, c0, 4 /* wait for interrupt */
> -
> - mcr p15, 0, r1, c1, c0, 0 /* restore d/i cache */
> -#endif
> mov pc, lr
> --
> 1.7.0.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
Kirill A. Shutemov

2010-06-30 20:03:46

by Daniel Walker

[permalink] [raw]
Subject: Re: [PATCH 04/33] Removing dead MSM7X00A_IDLE

On Wed, 2010-06-30 at 22:59 +0300, Kirill A. Shutemov wrote:
> On Wed, Jun 30, 2010 at 05:55:03PM +0200, Christoph Egger wrote:
> > MSM7X00A_IDLE doesn't exist in Kconfig, therefore removing all
> > references for it from the source code.
>
> It was removed in commit 1637de0c9. I'm not sure if it's correct.
>
> Brian Swetland added to CC list.

Yeah, it looks like it was missed in the original commit.

Daniel

--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.