2020-01-21 10:27:27

by Yannick FERTRE

Subject: [PATCH] drm/bridge/synopsys: dsi: missing post disable

From: Yannick Fertré <[email protected]>

Sometime the post_disable function is missing (not registered).

Signed-off-by: Yannick Fertré <[email protected]>
---
drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
index b18351b..12823ae 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
@@ -824,7 +824,8 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
* This needs to be fixed in the drm_bridge framework and the API
* needs to be updated to manage our own call chains...
*/
- dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
+ if (dsi->panel_bridge->funcs->post_disable)
+ dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);

if (phy_ops->power_off)
phy_ops->power_off(dsi->plat_data->priv_data);
--
2.7.4

2020-01-23 09:57:25

by Philippe Cornu

Subject: Re: [PATCH] drm/bridge/synopsys: dsi: missing post disable

Dear Yannick,
Thank you for your patch,

Reviewed-by: Philippe Cornu <[email protected]>

Philippe :-)

On 1/21/20 11:24 AM, Yannick Fertre wrote:
> From: Yannick Fertré <[email protected]>
>
> Sometime the post_disable function is missing (not registered).
>
> Signed-off-by: Yannick Fertré <[email protected]>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> index b18351b..12823ae 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> @@ -824,7 +824,8 @@ static void dw_mipi_dsi_bridge_post_disable(struct drm_bridge *bridge)
> * This needs to be fixed in the drm_bridge framework and the API
> * needs to be updated to manage our own call chains...
> */
> - dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
> + if (dsi->panel_bridge->funcs->post_disable)
> + dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge);
>
> if (phy_ops->power_off)
> phy_ops->power_off(dsi->plat_data->priv_data);
>