2020-04-14 14:02:48

by Hsin-Yi Wang

Subject: [PATCH 1/2] arm64: dts: mt8173: fix mdp aliases property name

Fix warning:
Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
index a212bf124e81..d1e9c41004b4 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
@@ -42,14 +42,14 @@ aliases {
dpi0 = &dpi0;
dsi0 = &dsi0;
dsi1 = &dsi1;
- mdp_rdma0 = &mdp_rdma0;
- mdp_rdma1 = &mdp_rdma1;
- mdp_rsz0 = &mdp_rsz0;
- mdp_rsz1 = &mdp_rsz1;
- mdp_rsz2 = &mdp_rsz2;
- mdp_wdma0 = &mdp_wdma0;
- mdp_wrot0 = &mdp_wrot0;
- mdp_wrot1 = &mdp_wrot1;
+ mdp-rdma0 = &mdp_rdma0;
+ mdp-rdma1 = &mdp_rdma1;
+ mdp-rsz0 = &mdp_rsz0;
+ mdp-rsz1 = &mdp_rsz1;
+ mdp-rsz2 = &mdp_rsz2;
+ mdp-wdma0 = &mdp_wdma0;
+ mdp-wrot0 = &mdp_wrot0;
+ mdp-wrot1 = &mdp_wrot1;
serial0 = &uart0;
serial1 = &uart1;
serial2 = &uart2;
--
2.26.0.110.g2183baf09c-goog

2020-04-14 14:02:49

by Hsin-Yi Wang

Subject: [PATCH 2/2] media: mtk-mdp: Use correct aliases name

aliases property name must include only lowercase and '-'. Fix in dts
and driver.

Signed-off-by: Hsin-Yi Wang <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
---
drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
index 14991685adb7..58abfbdfb82d 100644
--- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
+++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
@@ -15,10 +15,10 @@


static const char * const mtk_mdp_comp_stem[MTK_MDP_COMP_TYPE_MAX] = {
- "mdp_rdma",
- "mdp_rsz",
- "mdp_wdma",
- "mdp_wrot",
+ "mdp-rdma",
+ "mdp-rsz",
+ "mdp-wdma",
+ "mdp-wrot",
};

struct mtk_mdp_comp_match {
--
2.26.0.110.g2183baf09c-goog

2020-04-15 14:30:29

by Chun-Kuang Hu

Subject: Re: [PATCH 1/2] arm64: dts: mt8173: fix mdp aliases property name

Hi, Hsin-Yi

Hsin-Yi Wang <[email protected]> 於 2020年4月14日 週二 上午11:08寫道：
>
> Fix warning:
> Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Reviewed-by: Chun-Kuang Hu <[email protected]>

>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index a212bf124e81..d1e9c41004b4 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -42,14 +42,14 @@ aliases {
> dpi0 = &dpi0;
> dsi0 = &dsi0;
> dsi1 = &dsi1;
> - mdp_rdma0 = &mdp_rdma0;
> - mdp_rdma1 = &mdp_rdma1;
> - mdp_rsz0 = &mdp_rsz0;
> - mdp_rsz1 = &mdp_rsz1;
> - mdp_rsz2 = &mdp_rsz2;
> - mdp_wdma0 = &mdp_wdma0;
> - mdp_wrot0 = &mdp_wrot0;
> - mdp_wrot1 = &mdp_wrot1;
> + mdp-rdma0 = &mdp_rdma0;
> + mdp-rdma1 = &mdp_rdma1;
> + mdp-rsz0 = &mdp_rsz0;
> + mdp-rsz1 = &mdp_rsz1;
> + mdp-rsz2 = &mdp_rsz2;
> + mdp-wdma0 = &mdp_wdma0;
> + mdp-wrot0 = &mdp_wrot0;
> + mdp-wrot1 = &mdp_wrot1;
> serial0 = &uart0;
> serial1 = &uart1;
> serial2 = &uart2;
> --
> 2.26.0.110.g2183baf09c-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

2020-04-15 22:00:08

by Chun-Kuang Hu

Subject: Re: [PATCH 2/2] media: mtk-mdp: Use correct aliases name

Hi, Hsin-Yi:

Hsin-Yi Wang <[email protected]> 於 2020年4月14日 週二 上午11:08寫道：
>
> aliases property name must include only lowercase and '-'. Fix in dts
> and driver.
>

Reviewed-by: Chun-Kuang Hu <[email protected]>

> Signed-off-by: Hsin-Yi Wang <[email protected]>
> Reviewed-by: Matthias Brugger <[email protected]>
> ---
> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> index 14991685adb7..58abfbdfb82d 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> @@ -15,10 +15,10 @@
>
>
> static const char * const mtk_mdp_comp_stem[MTK_MDP_COMP_TYPE_MAX] = {
> - "mdp_rdma",
> - "mdp_rsz",
> - "mdp_wdma",
> - "mdp_wrot",
> + "mdp-rdma",
> + "mdp-rsz",
> + "mdp-wdma",
> + "mdp-wrot",
> };
>
> struct mtk_mdp_comp_match {
> --
> 2.26.0.110.g2183baf09c-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

2020-04-16 08:55:43

by Hans Verkuil

Subject: Re: [PATCH 1/2] arm64: dts: mt8173: fix mdp aliases property name

On 14/04/2020 05:08, Hsin-Yi Wang wrote:
> Fix warning:
> Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)

I'll merge patch 2/2 for 5.8. I assume that this dtsi patch is merged through
a mediatek subsystem?

Regards,

Hans

>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index a212bf124e81..d1e9c41004b4 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -42,14 +42,14 @@ aliases {
> dpi0 = &dpi0;
> dsi0 = &dsi0;
> dsi1 = &dsi1;
> - mdp_rdma0 = &mdp_rdma0;
> - mdp_rdma1 = &mdp_rdma1;
> - mdp_rsz0 = &mdp_rsz0;
> - mdp_rsz1 = &mdp_rsz1;
> - mdp_rsz2 = &mdp_rsz2;
> - mdp_wdma0 = &mdp_wdma0;
> - mdp_wrot0 = &mdp_wrot0;
> - mdp_wrot1 = &mdp_wrot1;
> + mdp-rdma0 = &mdp_rdma0;
> + mdp-rdma1 = &mdp_rdma1;
> + mdp-rsz0 = &mdp_rsz0;
> + mdp-rsz1 = &mdp_rsz1;
> + mdp-rsz2 = &mdp_rsz2;
> + mdp-wdma0 = &mdp_wdma0;
> + mdp-wrot0 = &mdp_wrot0;
> + mdp-wrot1 = &mdp_wrot1;
> serial0 = &uart0;
> serial1 = &uart1;
> serial2 = &uart2;
>

2020-05-16 15:11:36

by Matthias Brugger

Subject: Re: [PATCH 1/2] arm64: dts: mt8173: fix mdp aliases property name

On 16/04/2020 10:41, Hans Verkuil wrote:
> On 14/04/2020 05:08, Hsin-Yi Wang wrote:
>> Fix warning:
>> Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
>>
>> Signed-off-by: Hsin-Yi Wang <[email protected]>
>> ---
>> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 ++++++++--------
>> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> I'll merge patch 2/2 for 5.8. I assume that this dtsi patch is merged through
> a mediatek subsystem?
>

Correct. Now queued in v5.7-next/dts64

Thanks!

> Regards,
>
> Hans
>
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> index a212bf124e81..d1e9c41004b4 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
>> @@ -42,14 +42,14 @@ aliases {
>> dpi0 = &dpi0;
>> dsi0 = &dsi0;
>> dsi1 = &dsi1;
>> - mdp_rdma0 = &mdp_rdma0;
>> - mdp_rdma1 = &mdp_rdma1;
>> - mdp_rsz0 = &mdp_rsz0;
>> - mdp_rsz1 = &mdp_rsz1;
>> - mdp_rsz2 = &mdp_rsz2;
>> - mdp_wdma0 = &mdp_wdma0;
>> - mdp_wrot0 = &mdp_wrot0;
>> - mdp_wrot1 = &mdp_wrot1;
>> + mdp-rdma0 = &mdp_rdma0;
>> + mdp-rdma1 = &mdp_rdma1;
>> + mdp-rsz0 = &mdp_rsz0;
>> + mdp-rsz1 = &mdp_rsz1;
>> + mdp-rsz2 = &mdp_rsz2;
>> + mdp-wdma0 = &mdp_wdma0;
>> + mdp-wrot0 = &mdp_wrot0;
>> + mdp-wrot1 = &mdp_wrot1;
>> serial0 = &uart0;
>> serial1 = &uart1;
>> serial2 = &uart2;
>>
>