2017-11-22 21:06:48

by Woody Suwalski

[permalink] [raw]
Subject: [PATCH] 4.15 vmgfx boot warning

The 4.15 vmwgfx driver shows a warning during boot (32 bit x86)
It is caused by a mismatch between the result of vmw_enable_vblank() and
what the drm_atomic_helper expects:
   /...
   ret = drm_crtc_vblank_get(crtc);
   WARN_ONCE(ret != -EINVAL, "driver forgot to call
drm_crtc_vblank_off()\n");
   /...

Signed-off by: Woody Suwalski <[email protected]>

--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c    2017-11-22
15:29:46.511674079 -0500
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c    2017-11-22
15:30:35.344559592 -0500
@@ -1869,7 +1869,7 @@ u32 vmw_get_vblank_counter(struct drm_de
  */
 int vmw_enable_vblank(struct drm_device *dev, unsigned int pipe)
 {
-    return -ENOSYS;
+    return -EINVAL;
 }

 /**


From 1586177165767671412@xxx Fri Dec 08 01:27:04 +0000 2017
X-GM-THRID: 1586120225945082722
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread