2017-11-04 01:01:54

by Ed Cashin

[permalink] [raw]
Subject: Re: [PATCH] block/aoe: discover_timer: Convert timers to use timer_setup()

On 11/02/2017 07:31 PM, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer to
> all timer callbacks, switch to using the new timer_setup() and from_timer()
> to pass the timer pointer explicitly.
>
> This refactors the discover_timer to remove the needless locking and
> state machine used for synchronizing timer death. Using del_timer_sync()
> will already do the right thing.

Looks OK to me, thanks.

--
Ed

From 1582999083935096845@xxx Thu Nov 02 23:32:49 +0000 2017
X-GM-THRID: 1582999083935096845
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread