2017-11-03 14:18:44

by Niklas Cassel

[permalink] [raw]
Subject: Re: [PATCH v3 14/17] PCI: dwc: artpec6: Add support for endpoint mode

On 11/03/2017 11:23 AM, Arnd Bergmann wrote:
> On Fri, Nov 3, 2017 at 10:56 AM, Niklas Cassel <[email protected]> wrote:
>> On 11/02/2017 10:13 AM, Arnd Bergmann wrote:

> What I meant is that you can remove the #ifdef entirely if you add
>
> if (!IS_ENABLED(CONFIG_PCIE_ARTPEC6_HOST))
> return -ENODEV;
>
> to artpec6_pcie_probe(). Anything after that statement will get
> silently dropped by the compiler, including static functions and
> structures that are referenced indirectly from there.

Wow, this actually helps gcc with dead code elimination.
It was even possible to add those !IS_ENABLED the two different
case labels in the switch statement.
I get no unwanted symbols when looking at the vmlinux in gdb.

Great suggestion Arnd :)


Regards,
Niklas

From 1583040081442125425@xxx Fri Nov 03 10:24:27 +0000 2017
X-GM-THRID: 1582814679884309053
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread