2023-04-06 15:24:25

by Steven Rostedt

Subject: [PATCH] tracing/synthetic: Make lastcmd_mutex static

From: "Steven Rostedt (Google)" <[email protected]>

The lastcmd_mutex is only used in trace_events_synth.c and should be
static.

Link: https://lore.kernel.org/linux-trace-kernel/[email protected]/

Fixes: 4ccf11c4e8a8e ("tracing/synthetic: Fix races on freeing last_cmd")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Steven Rostedt (Google) <[email protected]>
---
kernel/trace/trace_events_synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
index f0ff730125bf..d6a70aff2410 100644
--- a/kernel/trace/trace_events_synth.c
+++ b/kernel/trace/trace_events_synth.c
@@ -44,7 +44,7 @@ enum { ERRORS };

static const char *err_text[] = { ERRORS };

-DEFINE_MUTEX(lastcmd_mutex);
+static DEFINE_MUTEX(lastcmd_mutex);
static char *last_cmd;

static int errpos(const char *str)
--
2.39.2

2023-04-06 15:35:37

by Mukesh Ojha

Subject: Re: [PATCH] tracing/synthetic: Make lastcmd_mutex static

On 4/6/2023 8:40 PM, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <[email protected]>
>
> The lastcmd_mutex is only used in trace_events_synth.c and should be
> static.
>
> Link: https://lore.kernel.org/linux-trace-kernel/[email protected]/
>
> Fixes: 4ccf11c4e8a8e ("tracing/synthetic: Fix races on freeing last_cmd")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Steven Rostedt (Google) <[email protected]>

You have just beat me in pushing this.

Reviewed-by: Mukesh Ojha <[email protected]>

-- Mukesh

> ---
> kernel/trace/trace_events_synth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
> index f0ff730125bf..d6a70aff2410 100644
> --- a/kernel/trace/trace_events_synth.c
> +++ b/kernel/trace/trace_events_synth.c
> @@ -44,7 +44,7 @@ enum { ERRORS };
>
> static const char *err_text[] = { ERRORS };
>
> -DEFINE_MUTEX(lastcmd_mutex);
> +static DEFINE_MUTEX(lastcmd_mutex);
> static char *last_cmd;
>
> static int errpos(const char *str)