Michael reports the parent_node() will never be invoked since the
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of it.
So we start removing it from the topology.h headers for each arch.
Dou Liyang (11):
arm64: numa: Remove the unused parent_node() macro
ia64: topology: Remove the unused parent_node() macro
metag/numa: Remove the unused parent_node() macro
MIPS: numa: Remove the unused parent_node() macro
powerpc/numa: Remove the unused parent_node() macro
s390/topology: Remove the unused parent_node() macro
sh/numa: Remove the unused parent_node() macro
sparc64/topology: Remove the unused parent_node() macro
tile/topology: Remove the unused parent_node() macro
x86/topology: Remove the unused parent_node() macro
asm-generic: numa: Remove the unused parent_node() macro
arch/arm64/include/asm/numa.h | 3 ---
arch/ia64/include/asm/topology.h | 7 -------
arch/metag/include/asm/topology.h | 1 -
arch/mips/include/asm/mach-ip27/topology.h | 1 -
arch/mips/include/asm/mach-loongson64/topology.h | 1 -
arch/powerpc/include/asm/topology.h | 2 --
arch/s390/include/asm/topology.h | 6 ------
arch/sh/include/asm/topology.h | 1 -
arch/sparc/include/asm/topology_64.h | 2 --
arch/tile/include/asm/topology.h | 6 ------
arch/x86/include/asm/topology.h | 6 ------
include/asm-generic/topology.h | 3 ---
12 files changed, 39 deletions(-)
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in POWERPC platform is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: [email protected]
---
arch/powerpc/include/asm/topology.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/include/asm/topology.h b/arch/powerpc/include/asm/topology.h
index dc4e159..2d84bca 100644
--- a/arch/powerpc/include/asm/topology.h
+++ b/arch/powerpc/include/asm/topology.h
@@ -16,8 +16,6 @@ struct device_node;
#include <asm/mmzone.h>
-#define parent_node(node) (node)
-
#define cpumask_of_node(node) ((node) == -1 ? \
cpu_all_mask : \
node_to_cpumask_map[node])
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in X86 platform is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: [email protected]
---
arch/x86/include/asm/topology.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h
index 6358a85..c1d2a98 100644
--- a/arch/x86/include/asm/topology.h
+++ b/arch/x86/include/asm/topology.h
@@ -75,12 +75,6 @@ static inline const struct cpumask *cpumask_of_node(int node)
extern void setup_node_to_cpumask_map(void);
-/*
- * Returns the number of the node containing Node 'node'. This
- * architecture is flat, so it is a pretty simple function!
- */
-#define parent_node(node) (node)
-
#define pcibus_to_node(bus) __pcibus_to_node(bus)
extern int __node_distance(int, int);
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in SPARC64 platform is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: [email protected]
---
arch/sparc/include/asm/topology_64.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
index ad5293f..0fcc9a0 100644
--- a/arch/sparc/include/asm/topology_64.h
+++ b/arch/sparc/include/asm/topology_64.h
@@ -10,8 +10,6 @@ static inline int cpu_to_node(int cpu)
return numa_cpu_lookup_table[cpu];
}
-#define parent_node(node) (node)
-
#define cpumask_of_node(node) ((node) == -1 ? \
cpu_all_mask : \
&numa_cpumask_lookup_table[node])
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in generic situation is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: [email protected]
---
include/asm-generic/topology.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/asm-generic/topology.h b/include/asm-generic/topology.h
index fc824e2..a91d842 100644
--- a/include/asm-generic/topology.h
+++ b/include/asm-generic/topology.h
@@ -44,9 +44,6 @@
#define cpu_to_mem(cpu) ((void)(cpu),0)
#endif
-#ifndef parent_node
-#define parent_node(node) ((void)(node),0)
-#endif
#ifndef cpumask_of_node
#define cpumask_of_node(node) ((void)node, cpu_online_mask)
#endif
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in METAG architecture is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: James Hogan <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
arch/metag/include/asm/topology.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/metag/include/asm/topology.h b/arch/metag/include/asm/topology.h
index e95f874..707c7f7 100644
--- a/arch/metag/include/asm/topology.h
+++ b/arch/metag/include/asm/topology.h
@@ -4,7 +4,6 @@
#ifdef CONFIG_NUMA
#define cpu_to_node(cpu) ((void)(cpu), 0)
-#define parent_node(node) ((void)(node), 0)
#define cpumask_of_node(node) ((void)node, cpu_online_mask)
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in tile platform is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Chris Metcalf <[email protected]>
---
arch/tile/include/asm/topology.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/tile/include/asm/topology.h b/arch/tile/include/asm/topology.h
index b11d5fc..635a0a4 100644
--- a/arch/tile/include/asm/topology.h
+++ b/arch/tile/include/asm/topology.h
@@ -29,12 +29,6 @@ static inline int cpu_to_node(int cpu)
return cpu_2_node[cpu];
}
-/*
- * Returns the number of the node containing Node 'node'.
- * This architecture is flat, so it is a pretty simple function!
- */
-#define parent_node(node) (node)
-
/* Returns a bitmask of CPUs on Node 'node'. */
static inline const struct cpumask *cpumask_of_node(int node)
{
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in ARM64 platform is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Michael Ellerman <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: [email protected]
---
arch/arm64/include/asm/numa.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h
index bf466d1..ef7b238 100644
--- a/arch/arm64/include/asm/numa.h
+++ b/arch/arm64/include/asm/numa.h
@@ -7,9 +7,6 @@
#define NR_NODE_MEMBLKS (MAX_NUMNODES * 2)
-/* currently, arm64 implements flat NUMA topology */
-#define parent_node(node) (node)
-
int __node_distance(int from, int to);
#define node_distance(a, b) __node_distance(a, b)
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in IA64(Itanium) platform is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: Fenghua Yu <[email protected]>
Cc: [email protected]
---
arch/ia64/include/asm/topology.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/ia64/include/asm/topology.h b/arch/ia64/include/asm/topology.h
index 3ad8f69..82f9bf7 100644
--- a/arch/ia64/include/asm/topology.h
+++ b/arch/ia64/include/asm/topology.h
@@ -34,13 +34,6 @@
&node_to_cpu_mask[node])
/*
- * Returns the number of the node containing Node 'nid'.
- * Not implemented here. Multi-level hierarchies detected with
- * the help of node_distance().
- */
-#define parent_node(nid) (nid)
-
-/*
* Determines the node for a given pci bus
*/
#define pcibus_to_node(bus) PCI_CONTROLLER(bus)->node
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in SUPERH platform is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Yoshinori Sato <[email protected]>
Cc: Rich Felker <[email protected]>
Cc: [email protected]
---
arch/sh/include/asm/topology.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sh/include/asm/topology.h b/arch/sh/include/asm/topology.h
index 358e3f5..6931f50 100644
--- a/arch/sh/include/asm/topology.h
+++ b/arch/sh/include/asm/topology.h
@@ -4,7 +4,6 @@
#ifdef CONFIG_NUMA
#define cpu_to_node(cpu) ((void)(cpu),0)
-#define parent_node(node) ((void)(node),0)
#define cpumask_of_node(node) ((void)node, cpu_online_mask)
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macros in both IP27 and Loongson64 are unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Ralf Baechle <[email protected]>
Cc: James Hogan <[email protected]>
Cc: [email protected]
---
arch/mips/include/asm/mach-ip27/topology.h | 1 -
arch/mips/include/asm/mach-loongson64/topology.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/mips/include/asm/mach-ip27/topology.h b/arch/mips/include/asm/mach-ip27/topology.h
index defd135..3fb7a0e 100644
--- a/arch/mips/include/asm/mach-ip27/topology.h
+++ b/arch/mips/include/asm/mach-ip27/topology.h
@@ -23,7 +23,6 @@ struct cpuinfo_ip27 {
extern struct cpuinfo_ip27 sn_cpu_info[NR_CPUS];
#define cpu_to_node(cpu) (sn_cpu_info[(cpu)].p_nodeid)
-#define parent_node(node) (node)
#define cpumask_of_node(node) ((node) == -1 ? \
cpu_all_mask : \
&hub_data(node)->h_cpus)
diff --git a/arch/mips/include/asm/mach-loongson64/topology.h b/arch/mips/include/asm/mach-loongson64/topology.h
index 0d8f3b5..bcb8856 100644
--- a/arch/mips/include/asm/mach-loongson64/topology.h
+++ b/arch/mips/include/asm/mach-loongson64/topology.h
@@ -4,7 +4,6 @@
#ifdef CONFIG_NUMA
#define cpu_to_node(cpu) (cpu_logical_map(cpu) >> 2)
-#define parent_node(node) (node)
#define cpumask_of_node(node) (&__node_data[(node)]->cpumask)
struct pci_bus;
--
2.5.5
Commit a7be6e5a7f8d ("mm: drop useless local parameters of
__register_one_node()") removes the last user of parent_node().
The parent_node() macro in S390 platform is unnecessary.
Remove it for cleanup.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Martin Schwidefsky <[email protected]>
Cc: Heiko Carstens <[email protected]>
Cc: Michael Holzheu <[email protected]>
Cc: [email protected]
---
arch/s390/include/asm/topology.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/s390/include/asm/topology.h b/arch/s390/include/asm/topology.h
index fa1bfce..5222da1 100644
--- a/arch/s390/include/asm/topology.h
+++ b/arch/s390/include/asm/topology.h
@@ -77,12 +77,6 @@ static inline const struct cpumask *cpumask_of_node(int node)
return &node_to_cpumask_map[node];
}
-/*
- * Returns the number of the node containing node 'node'. This
- * architecture is flat, so it is a pretty simple function!
- */
-#define parent_node(node) (node)
-
#define pcibus_to_node(bus) __pcibus_to_node(bus)
#define node_distance(a, b) __node_distance(a, b)
--
2.5.5
From: Dou Liyang <[email protected]>
Date: Wed, 26 Jul 2017 21:34:33 +0800
> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
> __register_one_node()") removes the last user of parent_node().
>
> The parent_node() macro in SPARC64 platform is unnecessary.
>
> Remove it for cleanup.
>
> Reported-by: Michael Ellerman <[email protected]>
> Signed-off-by: Dou Liyang <[email protected]>
Acked-by: David S. Miller <[email protected]>
On 7/26/2017 9:34 AM, Dou Liyang wrote:
> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
> __register_one_node()") removes the last user of parent_node().
>
> The parent_node() macro in tile platform is unnecessary.
>
> Remove it for cleanup.
>
> Reported-by: Michael Ellerman<[email protected]>
> Signed-off-by: Dou Liyang<[email protected]>
> Cc: Chris Metcalf<[email protected]>
> ---
> arch/tile/include/asm/topology.h | 6 ------
> 1 file changed, 6 deletions(-)
Acked-by: Chris Metcalf <[email protected]>
--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com
Dou Liyang <[email protected]> writes:
> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
> __register_one_node()") removes the last user of parent_node().
>
> The parent_node() macro in POWERPC platform is unnecessary.
>
> Remove it for cleanup.
>
> Reported-by: Michael Ellerman <[email protected]>
> Signed-off-by: Dou Liyang <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: [email protected]
> ---
> arch/powerpc/include/asm/topology.h | 2 --
> 1 file changed, 2 deletions(-)
Thanks for doing this series.
Acked-by: Michael Ellerman <[email protected]>
cheers
Hi Michael,
At 07/27/2017 10:21 AM, Michael Ellerman wrote:
> Dou Liyang <[email protected]> writes:
>
>> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
>> __register_one_node()") removes the last user of parent_node().
>>
>> The parent_node() macro in POWERPC platform is unnecessary.
>>
>> Remove it for cleanup.
>>
>> Reported-by: Michael Ellerman <[email protected]>
>> Signed-off-by: Dou Liyang <[email protected]>
>> Cc: Benjamin Herrenschmidt <[email protected]>
>> Cc: Paul Mackerras <[email protected]>
>> Cc: Michael Ellerman <[email protected]>
>> Cc: [email protected]
>> ---
>> arch/powerpc/include/asm/topology.h | 2 --
>> 1 file changed, 2 deletions(-)
>
> Thanks for doing this series.
>
It's my pleasure. :)
Sincerely,
dou
> Acked-by: Michael Ellerman <[email protected]>
>
> cheers
>
>
>
On Wed, Jul 26, 2017 at 09:34:31PM +0800, Dou Liyang wrote:
> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
> __register_one_node()") removes the last user of parent_node().
>
> The parent_node() macro in S390 platform is unnecessary.
>
> Remove it for cleanup.
>
> Reported-by: Michael Ellerman <[email protected]>
> Signed-off-by: Dou Liyang <[email protected]>
> Cc: Martin Schwidefsky <[email protected]>
> Cc: Heiko Carstens <[email protected]>
> Cc: Michael Holzheu <[email protected]>
> Cc: [email protected]
> ---
Are arch maintainers supposed to pick these patches up?
In any case: Acked-by: Heiko Carstens <[email protected]>
Commit-ID: dbe04493eddfaa89756ec9af8dde56206290182a
Gitweb: http://git.kernel.org/tip/dbe04493eddfaa89756ec9af8dde56206290182a
Author: Dou Liyang <[email protected]>
AuthorDate: Wed, 26 Jul 2017 21:34:35 +0800
Committer: Ingo Molnar <[email protected]>
CommitDate: Thu, 27 Jul 2017 10:53:00 +0200
x86/topology: Remove the unused parent_node() macro
Commit:
a7be6e5a7f8d ("mm: drop useless local parameters of __register_one_node()")
... removed the last user of parent_node(), so remove the macro.
Reported-by: Michael Ellerman <[email protected]>
Signed-off-by: Dou Liyang <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/include/asm/topology.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/x86/include/asm/topology.h b/arch/x86/include/asm/topology.h
index 6358a85..c1d2a98 100644
--- a/arch/x86/include/asm/topology.h
+++ b/arch/x86/include/asm/topology.h
@@ -75,12 +75,6 @@ static inline const struct cpumask *cpumask_of_node(int node)
extern void setup_node_to_cpumask_map(void);
-/*
- * Returns the number of the node containing Node 'node'. This
- * architecture is flat, so it is a pretty simple function!
- */
-#define parent_node(node) (node)
-
#define pcibus_to_node(bus) __pcibus_to_node(bus)
extern int __node_distance(int, int);
On Wed, Jul 26, 2017 at 09:34:26PM +0800, Dou Liyang wrote:
> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
> __register_one_node()") removes the last user of parent_node().
>
> The parent_node() macro in ARM64 platform is unnecessary.
>
> Remove it for cleanup.
>
> Reported-by: Michael Ellerman <[email protected]>
> Signed-off-by: Dou Liyang <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: [email protected]
> ---
> arch/arm64/include/asm/numa.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h
> index bf466d1..ef7b238 100644
> --- a/arch/arm64/include/asm/numa.h
> +++ b/arch/arm64/include/asm/numa.h
> @@ -7,9 +7,6 @@
>
> #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2)
>
> -/* currently, arm64 implements flat NUMA topology */
> -#define parent_node(node) (node)
> -
Acked-by: Will Deacon <[email protected]>
Where you intending for this to go via the arm64 tree?
Will
Hi will,
At 08/04/2017 09:30 PM, Will Deacon wrote:
> On Wed, Jul 26, 2017 at 09:34:26PM +0800, Dou Liyang wrote:
>> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
>> __register_one_node()") removes the last user of parent_node().
>>
>> The parent_node() macro in ARM64 platform is unnecessary.
>>
>> Remove it for cleanup.
>>
>> Reported-by: Michael Ellerman <[email protected]>
>> Signed-off-by: Dou Liyang <[email protected]>
>> Cc: Michael Ellerman <[email protected]>
>> Cc: Will Deacon <[email protected]>
>> Cc: [email protected]
>> ---
>> arch/arm64/include/asm/numa.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h
>> index bf466d1..ef7b238 100644
>> --- a/arch/arm64/include/asm/numa.h
>> +++ b/arch/arm64/include/asm/numa.h
>> @@ -7,9 +7,6 @@
>>
>> #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2)
>>
>> -/* currently, arm64 implements flat NUMA topology */
>> -#define parent_node(node) (node)
>> -
>
> Acked-by: Will Deacon <[email protected]>
>
> Where you intending for this to go via the arm64 tree?
>
I intend for this to go to upstream tree. shall we?
Thanks
dou.
> Will
>
>
>
On Fri, Aug 04, 2017 at 11:28:36PM +0800, Dou Liyang wrote:
> Hi will,
>
> At 08/04/2017 09:30 PM, Will Deacon wrote:
> > On Wed, Jul 26, 2017 at 09:34:26PM +0800, Dou Liyang wrote:
> > > Commit a7be6e5a7f8d ("mm: drop useless local parameters of
> > > __register_one_node()") removes the last user of parent_node().
> > >
> > > The parent_node() macro in ARM64 platform is unnecessary.
> > >
> > > Remove it for cleanup.
> > >
> > > Reported-by: Michael Ellerman <[email protected]>
> > > Signed-off-by: Dou Liyang <[email protected]>
> > > Cc: Michael Ellerman <[email protected]>
> > > Cc: Will Deacon <[email protected]>
> > > Cc: [email protected]
> > > ---
> > > arch/arm64/include/asm/numa.h | 3 ---
> > > 1 file changed, 3 deletions(-)
> > >
> > > diff --git a/arch/arm64/include/asm/numa.h b/arch/arm64/include/asm/numa.h
> > > index bf466d1..ef7b238 100644
> > > --- a/arch/arm64/include/asm/numa.h
> > > +++ b/arch/arm64/include/asm/numa.h
> > > @@ -7,9 +7,6 @@
> > >
> > > #define NR_NODE_MEMBLKS (MAX_NUMNODES * 2)
> > >
> > > -/* currently, arm64 implements flat NUMA topology */
> > > -#define parent_node(node) (node)
> > > -
> >
> > Acked-by: Will Deacon <[email protected]>
> >
> > Where you intending for this to go via the arm64 tree?
>
> I intend for this to go to upstream tree. shall we?
Queued for 4.14. Thanks.
--
Catalin
Dou Liyang <[email protected]> writes:
> Hi Michael,
>
> At 07/27/2017 10:21 AM, Michael Ellerman wrote:
>> Dou Liyang <[email protected]> writes:
>>
>>> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
>>> __register_one_node()") removes the last user of parent_node().
>>>
>>> The parent_node() macro in POWERPC platform is unnecessary.
>>>
>>> Remove it for cleanup.
>>>
>>> Reported-by: Michael Ellerman <[email protected]>
>>> Signed-off-by: Dou Liyang <[email protected]>
>>> Cc: Benjamin Herrenschmidt <[email protected]>
>>> Cc: Paul Mackerras <[email protected]>
>>> Cc: Michael Ellerman <[email protected]>
>>> Cc: [email protected]
>>> ---
>>> arch/powerpc/include/asm/topology.h | 2 --
>>> 1 file changed, 2 deletions(-)
>>
>> Thanks for doing this series.
>
> It's my pleasure. :)
Seems other arch maintainers are merging these patches individually, so
I grabbed this one and put it in the powerpc tree.
cheers
Hi Heiko,
At 07/27/2017 04:19 PM, Heiko Carstens wrote:
> On Wed, Jul 26, 2017 at 09:34:31PM +0800, Dou Liyang wrote:
>> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
>> __register_one_node()") removes the last user of parent_node().
>>
>> The parent_node() macro in S390 platform is unnecessary.
>>
>> Remove it for cleanup.
>>
>> Reported-by: Michael Ellerman <[email protected]>
>> Signed-off-by: Dou Liyang <[email protected]>
>> Cc: Martin Schwidefsky <[email protected]>
>> Cc: Heiko Carstens <[email protected]>
>> Cc: Michael Holzheu <[email protected]>
>> Cc: [email protected]
>> ---
>
> Are arch maintainers supposed to pick these patches up?
>
Yes, As Michael said, It seems these patches are merging individually.
can you merge this patch in s390 tree?
> In any case: Acked-by: Heiko Carstens <[email protected]>
>
>
Thanks,
dou.
On Wed, 2017-07-26 at 13:34:30 UTC, Dou Liyang wrote:
> Commit a7be6e5a7f8d ("mm: drop useless local parameters of
> __register_one_node()") removes the last user of parent_node().
>
> The parent_node() macro in POWERPC platform is unnecessary.
>
> Remove it for cleanup.
>
> Reported-by: Michael Ellerman <[email protected]>
> Signed-off-by: Dou Liyang <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> Cc: Michael Ellerman <[email protected]>
> Cc: [email protected]
> Acked-by: Michael Ellerman <[email protected]>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7baebe54a64af44dc34d0bd51462f0
cheers