2019-04-17 10:56:59

by Colin King

Subject: [PATCH] perf test: fix spelling mistake "leadking" -> "leaking"

From: Colin Ian King <[email protected]>

There are a couple of spelling mistakes in test assert messages. Fix them.

Signed-off-by: Colin Ian King <[email protected]>
---
tools/perf/tests/dso-data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index 7f6c52021e41..946ab4b63acd 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests/dso-data.c
@@ -304,7 +304,7 @@ int test__dso_data_cache(struct test *test __maybe_unused, int subtest __maybe_u
/* Make sure we did not leak any file descriptor. */
nr_end = open_files_cnt();
pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
- TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
+ TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
return 0;
}

@@ -380,6 +380,6 @@ int test__dso_data_reopen(struct test *test __maybe_unused, int subtest __maybe_
/* Make sure we did not leak any file descriptor. */
nr_end = open_files_cnt();
pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
- TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
+ TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
return 0;
}
--
2.20.1

2019-04-17 11:08:42

by Mukesh Ojha

Subject: Re: [PATCH] perf test: fix spelling mistake "leadking" -> "leaking"

On 4/17/2019 4:25 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> There are a couple of spelling mistakes in test assert messages. Fix them.
>
> Signed-off-by: Colin Ian King <[email protected]>

Well, how are you shooting these mistakes one after the other?

Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> tools/perf/tests/dso-data.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
> index 7f6c52021e41..946ab4b63acd 100644
> --- a/tools/perf/tests/dso-data.c
> +++ b/tools/perf/tests/dso-data.c
> @@ -304,7 +304,7 @@ int test__dso_data_cache(struct test *test __maybe_unused, int subtest __maybe_u
> /* Make sure we did not leak any file descriptor. */
> nr_end = open_files_cnt();
> pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
> - TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
> + TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
> return 0;
> }
>
> @@ -380,6 +380,6 @@ int test__dso_data_reopen(struct test *test __maybe_unused, int subtest __maybe_
> /* Make sure we did not leak any file descriptor. */
> nr_end = open_files_cnt();
> pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
> - TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
> + TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
> return 0;
> }

2019-04-17 11:10:33

by Colin King

Subject: Re: [PATCH] perf test: fix spelling mistake "leadking" -> "leaking"

On 17/04/2019 12:07, Mukesh Ojha wrote:
>
> On 4/17/2019 4:25 PM, Colin King wrote:
>> From: Colin Ian King <[email protected]>
>>
>> There are a couple of spelling mistakes in test assert messages. Fix
>> them.
>>
>> Signed-off-by: Colin Ian King <[email protected]>
>
> Well, how are you shooting these mistakes one after the other?

I've got a spelling checker and I'm working down a list of 65948
potential mistakes. I'm doing this between kernel build + debug cycles
while I'm waiting for kernels to build and tests to complete.



>
> Reviewed-by: Mukesh Ojha <[email protected]>
>
> Cheers,
> -Mukesh
>
>> ---
>>   tools/perf/tests/dso-data.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
>> index 7f6c52021e41..946ab4b63acd 100644
>> --- a/tools/perf/tests/dso-data.c
>> +++ b/tools/perf/tests/dso-data.c
>> @@ -304,7 +304,7 @@ int test__dso_data_cache(struct test *test
>> __maybe_unused, int subtest __maybe_u
>>       /* Make sure we did not leak any file descriptor. */
>>       nr_end = open_files_cnt();
>>       pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
>> -    TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
>> +    TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
>>       return 0;
>>   }
>>   @@ -380,6 +380,6 @@ int test__dso_data_reopen(struct test *test
>> __maybe_unused, int subtest __maybe_
>>       /* Make sure we did not leak any file descriptor. */
>>       nr_end = open_files_cnt();
>>       pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
>> -    TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
>> +    TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
>>       return 0;
>>   }

2019-04-17 17:39:42

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf test: fix spelling mistake "leadking" -> "leaking"

Em Wed, Apr 17, 2019 at 04:37:24PM +0530, Mukesh Ojha escreveu:
>
> On 4/17/2019 4:25 PM, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > There are a couple of spelling mistakes in test assert messages. Fix them.
> >
> > Signed-off-by: Colin Ian King <[email protected]>
>
> Well, how are you shooting these mistakes one after the other?
>
> Reviewed-by: Mukesh Ojha <[email protected]>

Thanks, applied.

- Arnaldo

2019-05-18 10:06:00

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/core] perf test: Fix spelling mistake "leadking" -> "leaking"

Commit-ID: 1455ea2391be5a5bf0a53258af94fa2abbd73cca
Gitweb: https://git.kernel.org/tip/1455ea2391be5a5bf0a53258af94fa2abbd73cca
Author: Colin Ian King <[email protected]>
AuthorDate: Wed, 17 Apr 2019 11:55:39 +0100
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Wed, 15 May 2019 16:36:46 -0300

perf test: Fix spelling mistake "leadking" -> "leaking"

There are a couple of spelling mistakes in test assert messages. Fix them.

Signed-off-by: Colin King <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>
Cc: Alexander Shishkin <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/tests/dso-data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
index 7f6c52021e41..946ab4b63acd 100644
--- a/tools/perf/tests/dso-data.c
+++ b/tools/perf/tests/dso-data.c
@@ -304,7 +304,7 @@ int test__dso_data_cache(struct test *test __maybe_unused, int subtest __maybe_u
/* Make sure we did not leak any file descriptor. */
nr_end = open_files_cnt();
pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
- TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
+ TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
return 0;
}

@@ -380,6 +380,6 @@ int test__dso_data_reopen(struct test *test __maybe_unused, int subtest __maybe_
/* Make sure we did not leak any file descriptor. */
nr_end = open_files_cnt();
pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
- TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
+ TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
return 0;
}