2023-07-13 20:27:58

by Andrew Davis

Subject: [PATCH v2] phy: ti: gmii-sel: Allow parent to not be syscon node

If the parent node is not a syscon type, then fallback and check
if we can get a regmap from our own node. This no longer forces
us to make the parent of this node a syscon node when that might
not be appropriate.

Signed-off-by: Andrew Davis <[email protected]>
---

Changes from v1:
- Rebased on v6.5-rc1

drivers/phy/ti/phy-gmii-sel.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c
index 6286cf25a4264..555b323f45da1 100644
--- a/drivers/phy/ti/phy-gmii-sel.c
+++ b/drivers/phy/ti/phy-gmii-sel.c
@@ -465,9 +465,12 @@ static int phy_gmii_sel_probe(struct platform_device *pdev)

priv->regmap = syscon_node_to_regmap(node->parent);
if (IS_ERR(priv->regmap)) {
- ret = PTR_ERR(priv->regmap);
- dev_err(dev, "Failed to get syscon %d\n", ret);
- return ret;
+ priv->regmap = device_node_to_regmap(node);
+ if (IS_ERR(priv->regmap)) {
+ ret = PTR_ERR(priv->regmap);
+ dev_err(dev, "Failed to get syscon %d\n", ret);
+ return ret;
+ }
}

ret = phy_gmii_sel_init_ports(priv);
--
2.39.2

2023-07-14 06:36:27

by Siddharth Vadapalli

Subject: Re: [PATCH v2] phy: ti: gmii-sel: Allow parent to not be syscon node

On 14/07/23 01:39, Andrew Davis wrote:
> If the parent node is not a syscon type, then fallback and check
> if we can get a regmap from our own node. This no longer forces
> us to make the parent of this node a syscon node when that might
> not be appropriate.
>
> Signed-off-by: Andrew Davis <[email protected]>

Reviewed-by: Siddharth Vadapalli <[email protected]>

> ---
>
> Changes from v1:
> - Rebased on v6.5-rc1
>
> drivers/phy/ti/phy-gmii-sel.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c
> index 6286cf25a4264..555b323f45da1 100644
> --- a/drivers/phy/ti/phy-gmii-sel.c
> +++ b/drivers/phy/ti/phy-gmii-sel.c
> @@ -465,9 +465,12 @@ static int phy_gmii_sel_probe(struct platform_device *pdev)
>
> priv->regmap = syscon_node_to_regmap(node->parent);
> if (IS_ERR(priv->regmap)) {
> - ret = PTR_ERR(priv->regmap);
> - dev_err(dev, "Failed to get syscon %d\n", ret);
> - return ret;
> + priv->regmap = device_node_to_regmap(node);
> + if (IS_ERR(priv->regmap)) {
> + ret = PTR_ERR(priv->regmap);
> + dev_err(dev, "Failed to get syscon %d\n", ret);
> + return ret;
> + }
> }
>
> ret = phy_gmii_sel_init_ports(priv);

--
Regards,
Siddharth.

2023-07-14 11:52:43

by Roger Quadros

Subject: Re: [PATCH v2] phy: ti: gmii-sel: Allow parent to not be syscon node

On 13/07/2023 23:09, Andrew Davis wrote:
> If the parent node is not a syscon type, then fallback and check
> if we can get a regmap from our own node. This no longer forces
> us to make the parent of this node a syscon node when that might
> not be appropriate.
>
> Signed-off-by: Andrew Davis <[email protected]>

Reviewed-by: Roger Quadros <[email protected]>

2023-07-17 06:34:54

by Vinod Koul

Subject: Re: [PATCH v2] phy: ti: gmii-sel: Allow parent to not be syscon node

On Thu, 13 Jul 2023 15:09:57 -0500, Andrew Davis wrote:
> If the parent node is not a syscon type, then fallback and check
> if we can get a regmap from our own node. This no longer forces
> us to make the parent of this node a syscon node when that might
> not be appropriate.
>
>

Applied, thanks!

[1/1] phy: ti: gmii-sel: Allow parent to not be syscon node
commit: 1fdfa7cccd35519d97a1f301b8143ea4196b2d16

Best regards,
--
~Vinod