2023-03-15 15:58:34

by Tom Rix

Subject: [PATCH] clk: qcom: remove unused variables gpucc_parent_data,map_2

gcc with W=1 reports these errors
drivers/clk/qcom/gpucc-sm6375.c:145:37: error:
‘gpucc_parent_data_2’ defined but not used [-Werror=unused-const-variable=]
145 | static const struct clk_parent_data gpucc_parent_data_2[] = {
| ^~~~~~~~~~~~~~~~~~~
drivers/clk/qcom/gpucc-sm6375.c:139:32: error:
‘gpucc_parent_map_2’ defined but not used [-Werror=unused-const-variable=]
139 | static const struct parent_map gpucc_parent_map_2[] = {
| ^~~~~~~~~~~~~~~~~~

These variables are not used, so remove them.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/clk/qcom/gpucc-sm6375.c | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/drivers/clk/qcom/gpucc-sm6375.c b/drivers/clk/qcom/gpucc-sm6375.c
index eb9ffa956950..d8f4c4b59f1b 100644
--- a/drivers/clk/qcom/gpucc-sm6375.c
+++ b/drivers/clk/qcom/gpucc-sm6375.c
@@ -136,18 +136,6 @@ static const struct clk_parent_data gpucc_parent_data_1[] = {
{ .index = DT_GCC_GPU_GPLL0_CLK_SRC },
};

-static const struct parent_map gpucc_parent_map_2[] = {
- { P_BI_TCXO, 0 },
- { P_GCC_GPU_GPLL0_CLK_SRC, 5 },
- { P_GCC_GPU_GPLL0_DIV_CLK_SRC, 6 },
-};
-
-static const struct clk_parent_data gpucc_parent_data_2[] = {
- { .index = P_BI_TCXO },
- { .index = DT_GCC_GPU_GPLL0_CLK_SRC },
- { .index = DT_GCC_GPU_GPLL0_DIV_CLK_SRC },
-};
-
static const struct freq_tbl ftbl_gpucc_gmu_clk_src[] = {
F(200000000, P_GCC_GPU_GPLL0_DIV_CLK_SRC, 1.5, 0, 0),
{ }
--
2.27.0

2023-03-15 16:02:23

by Konrad Dybcio

Subject: Re: [PATCH] clk: qcom: remove unused variables gpucc_parent_data,map_2

On 15.03.2023 16:56, Tom Rix wrote:
> gcc with W=1 reports these errors
> drivers/clk/qcom/gpucc-sm6375.c:145:37: error:
> ‘gpucc_parent_data_2’ defined but not used [-Werror=unused-const-variable=]
> 145 | static const struct clk_parent_data gpucc_parent_data_2[] = {
> | ^~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gpucc-sm6375.c:139:32: error:
> ‘gpucc_parent_map_2’ defined but not used [-Werror=unused-const-variable=]
> 139 | static const struct parent_map gpucc_parent_map_2[] = {
> | ^~~~~~~~~~~~~~~~~~
>
> These variables are not used, so remove them.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/clk/qcom/gpucc-sm6375.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/clk/qcom/gpucc-sm6375.c b/drivers/clk/qcom/gpucc-sm6375.c
> index eb9ffa956950..d8f4c4b59f1b 100644
> --- a/drivers/clk/qcom/gpucc-sm6375.c
> +++ b/drivers/clk/qcom/gpucc-sm6375.c
> @@ -136,18 +136,6 @@ static const struct clk_parent_data gpucc_parent_data_1[] = {
> { .index = DT_GCC_GPU_GPLL0_CLK_SRC },
> };
>
> -static const struct parent_map gpucc_parent_map_2[] = {
> - { P_BI_TCXO, 0 },
> - { P_GCC_GPU_GPLL0_CLK_SRC, 5 },
> - { P_GCC_GPU_GPLL0_DIV_CLK_SRC, 6 },
> -};
> -
> -static const struct clk_parent_data gpucc_parent_data_2[] = {
> - { .index = P_BI_TCXO },
> - { .index = DT_GCC_GPU_GPLL0_CLK_SRC },
> - { .index = DT_GCC_GPU_GPLL0_DIV_CLK_SRC },
> -};
> -
> static const struct freq_tbl ftbl_gpucc_gmu_clk_src[] = {
> F(200000000, P_GCC_GPU_GPLL0_DIV_CLK_SRC, 1.5, 0, 0),
> { }

2023-03-15 23:35:50

by Bjorn Andersson

Subject: Re: [PATCH] clk: qcom: remove unused variables gpucc_parent_data,map_2

On Wed, 15 Mar 2023 11:56:30 -0400, Tom Rix wrote:
> gcc with W=1 reports these errors
> drivers/clk/qcom/gpucc-sm6375.c:145:37: error:
> ‘gpucc_parent_data_2’ defined but not used [-Werror=unused-const-variable=]
> 145 | static const struct clk_parent_data gpucc_parent_data_2[] = {
> | ^~~~~~~~~~~~~~~~~~~
> drivers/clk/qcom/gpucc-sm6375.c:139:32: error:
> ‘gpucc_parent_map_2’ defined but not used [-Werror=unused-const-variable=]
> 139 | static const struct parent_map gpucc_parent_map_2[] = {
> | ^~~~~~~~~~~~~~~~~~
>
> [...]

Applied, thanks!

[1/1] clk: qcom: remove unused variables gpucc_parent_data,map_2
commit: 54ed70b57623e18f6c18f510cbe1e741bca89f34

Best regards,
--
Bjorn Andersson <[email protected]>