2023-11-16 12:14:22

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings

On 16/11/2023 03:30, Delphine CC Chiu wrote:
> Add a device tree bindings for ltc4286 device.
>
> Signed-off-by: Delphine CC Chiu <[email protected]>
>
> -------------------------------------------------------------
> Changelog:
> v5 - Add hyphen under "Changelog" in commit message

Apply your patch from the list and check the result... You can easily
see it's broken. We asked about ---. Please read the message carefully.

Best regards,
Krzysztof


2023-11-16 14:31:15

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v5 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings

On Thu, Nov 16, 2023 at 01:13:58PM +0100, Krzysztof Kozlowski wrote:
> On 16/11/2023 03:30, Delphine CC Chiu wrote:
> > Add a device tree bindings for ltc4286 device.
> >
> > Signed-off-by: Delphine CC Chiu <[email protected]>
> >
> > -------------------------------------------------------------
> > Changelog:
> > v5 - Add hyphen under "Changelog" in commit message
>
> Apply your patch from the list and check the result... You can easily
> see it's broken. We asked about ---. Please read the message carefully.

My reviewed-by was also omitted again, but I suppose that is a good
thing since I conditionally gave that based on the changelog being
fixed!

Attachments:
(No filename) (690.00 B)
 signature.asc (235.00 B)
 Download all attachments
Subject: RE: [PATCH v5 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings

> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Thursday, November 16, 2023 8:14 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <[email protected]>;
> [email protected]; Jean Delvare <[email protected]>; Guenter Roeck
> <[email protected]>; Rob Herring <[email protected]>; Krzysztof Kozlowski
> <[email protected]>; Conor Dooley <[email protected]>
> Cc: Jonathan Corbet <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: Re: [PATCH v5 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver
> bindings
>
> Security Reminder: Please be aware that this email is sent by an external
> sender.
>
> On 16/11/2023 03:30, Delphine CC Chiu wrote:
> > Add a device tree bindings for ltc4286 device.
> >
> > Signed-off-by: Delphine CC Chiu <[email protected]>
> >
> > -------------------------------------------------------------
> > Changelog:
> > v5 - Add hyphen under "Changelog" in commit message
>
> Apply your patch from the list and check the result... You can easily see it's
> broken. We asked about ---. Please read the message carefully.

We will add ---
Thanks.

>
> Best regards,
> Krzysztof