2021-06-01 06:42:46

by Zhen Lei

Subject: [PATCH 1/1] mcb: Use DEFINE_RES_MEM() to simplify code

The value of '.end' should be "start + size - 1". So the previous writing
should have omitted subtracted 1.

Signed-off-by: Zhen Lei <[email protected]>
---
drivers/mcb/mcb-lpc.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/mcb/mcb-lpc.c b/drivers/mcb/mcb-lpc.c
index 506676754538b9e..53decd89876ee1b 100644
--- a/drivers/mcb/mcb-lpc.c
+++ b/drivers/mcb/mcb-lpc.c
@@ -105,17 +105,8 @@ static int mcb_lpc_create_platform_device(const struct dmi_system_id *id)
return ret;
}

-static struct resource sc24_fpga_resource = {
- .start = 0xe000e000,
- .end = 0xe000e000 + CHAM_HEADER_SIZE,
- .flags = IORESOURCE_MEM,
-};
-
-static struct resource sc31_fpga_resource = {
- .start = 0xf000e000,
- .end = 0xf000e000 + CHAM_HEADER_SIZE,
- .flags = IORESOURCE_MEM,
-};
+static struct resource sc24_fpga_resource = DEFINE_RES_MEM(0xe000e000, CHAM_HEADER_SIZE);
+static struct resource sc31_fpga_resource = DEFINE_RES_MEM(0xf000e000, CHAM_HEADER_SIZE);

static struct platform_driver mcb_lpc_driver = {
.driver = {
--
2.26.0.106.g9fadedd

2021-06-01 13:27:32

by Johannes Thumshirn

Subject: Re: [PATCH 1/1] mcb: Use DEFINE_RES_MEM() to simplify code

Am 01.06.21 um 08:40 schrieb Zhen Lei:
> The value of '.end' should be "start + size - 1". So the previous writing
> should have omitted subtracted 1.
>
> Signed-off-by: Zhen Lei <[email protected]>
> ---

Thanks applied