2023-07-25 16:08:17

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] phy: starfive: StarFive PHYs should depend on ARCH_STARFIVE

The various StarFive PHYs are only present on StarFive SoCs. Hence add
a dependency on ARCH_STARFIVE, to prevent asking the user about these
drivers when configuring a kernel without StarFive SoC support.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/phy/starfive/Kconfig | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
index a560533a674ee0a5..4457b3872aa146a4 100644
--- a/drivers/phy/starfive/Kconfig
+++ b/drivers/phy/starfive/Kconfig
@@ -3,6 +3,8 @@
# Phy drivers for StarFive platforms
#

+if ARCH_STARFIVE || COMPILE_TEST
+
config PHY_STARFIVE_JH7110_DPHY_RX
tristate "StarFive JH7110 D-PHY RX support"
select GENERIC_PHY
@@ -31,3 +33,5 @@ config PHY_STARFIVE_JH7110_USB
used with the Cadence USB controller.
If M is selected, the module will be called
phy-jh7110-usb.ko.
+
+endif # ARCH_STARFIVE || COMPILE_TEST
--
2.34.1



2023-07-26 02:51:21

by Changhuang Liang

[permalink] [raw]
Subject: Re: [PATCH] phy: starfive: StarFive PHYs should depend on ARCH_STARFIVE



On 2023/7/25 23:49, Geert Uytterhoeven wrote:
> The various StarFive PHYs are only present on StarFive SoCs. Hence add
> a dependency on ARCH_STARFIVE, to prevent asking the user about these
> drivers when configuring a kernel without StarFive SoC support.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/phy/starfive/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/phy/starfive/Kconfig b/drivers/phy/starfive/Kconfig
> index a560533a674ee0a5..4457b3872aa146a4 100644
> --- a/drivers/phy/starfive/Kconfig
> +++ b/drivers/phy/starfive/Kconfig
> @@ -3,6 +3,8 @@
> # Phy drivers for StarFive platforms
> #
>
> +if ARCH_STARFIVE || COMPILE_TEST
> +
> config PHY_STARFIVE_JH7110_DPHY_RX
> tristate "StarFive JH7110 D-PHY RX support"
> select GENERIC_PHY
> @@ -31,3 +33,5 @@ config PHY_STARFIVE_JH7110_USB
> used with the Cadence USB controller.
> If M is selected, the module will be called
> phy-jh7110-usb.ko.
> +
> +endif # ARCH_STARFIVE || COMPILE_TEST

For dphy rx parts:

Acked-by: Changhuang Liang <[email protected]>

Thanks,
Changhuang

2023-07-26 13:57:07

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] phy: starfive: StarFive PHYs should depend on ARCH_STARFIVE


On Tue, 25 Jul 2023 17:49:27 +0200, Geert Uytterhoeven wrote:
> The various StarFive PHYs are only present on StarFive SoCs. Hence add
> a dependency on ARCH_STARFIVE, to prevent asking the user about these
> drivers when configuring a kernel without StarFive SoC support.
>
>

Applied, thanks!

[1/1] phy: starfive: StarFive PHYs should depend on ARCH_STARFIVE
commit: e7379477f4478c290be47cde3ad8a39d5ff561d2

Best regards,
--
~Vinod