2020-05-18 01:07:42

by Lance Digby

Subject: [PATCH v1 target] target: Add initiatorname to NON_EXISTENT_LUN error

The NON_EXISTENT_LUN error can be written without an error condition
on the initiator responsible. Adding the initiatorname to this message
will reduce the effort required to fix this when many initiators are
supported by a target.

This version ensures the initiator name is also printed on the same
message in transport_lookup_tmr_lun for consistency.

Signed-off-by: Lance Digby <[email protected]>
---
drivers/target/target_core_device.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 4cee113..15064a5 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -100,9 +100,10 @@
*/
if (unpacked_lun != 0) {
pr_err("TARGET_CORE[%s]: Detected NON_EXISTENT_LUN"
- " Access for 0x%08llx\n",
+ " Access for 0x%08llx from %s\n",
se_cmd->se_tfo->fabric_name,
- unpacked_lun);
+ unpacked_lun,
+ nacl->initiatorname);
return TCM_NON_EXISTENT_LUN;
}

@@ -174,9 +175,10 @@ int transport_lookup_tmr_lun(struct se_cmd *se_cmd, u64 unpacked_lun)

if (!se_lun) {
pr_debug("TARGET_CORE[%s]: Detected NON_EXISTENT_LUN"
- " Access for 0x%08llx\n",
+ " Access for 0x%08llx for %s\n",
se_cmd->se_tfo->fabric_name,
- unpacked_lun);
+ unpacked_lun,
+ nacl->initiatorname);
return -ENODEV;
}
se_cmd->se_dev = rcu_dereference_raw(se_lun->lun_se_dev);
--
1.8.3.1

2020-05-18 20:04:41

by Mike Christie

Subject: Re: [PATCH v1 target] target: Add initiatorname to NON_EXISTENT_LUN error

On 5/17/20 8:02 PM, Lance Digby wrote:
> The NON_EXISTENT_LUN error can be written without an error condition
> on the initiator responsible. Adding the initiatorname to this message
> will reduce the effort required to fix this when many initiators are
> supported by a target.
>
> This version ensures the initiator name is also printed on the same
> message in transport_lookup_tmr_lun for consistency.
>

Reviewed-by: Mike Christie <[email protected]>

2020-05-20 02:32:27

by Martin K. Petersen

Subject: Re: [PATCH v1 target] target: Add initiatorname to NON_EXISTENT_LUN error

On Mon, 18 May 2020 11:02:16 +1000, Lance Digby wrote:

> The NON_EXISTENT_LUN error can be written without an error condition
> on the initiator responsible. Adding the initiatorname to this message
> will reduce the effort required to fix this when many initiators are
> supported by a target.
>
> This version ensures the initiator name is also printed on the same
> message in transport_lookup_tmr_lun for consistency.

Applied to 5.8/scsi-queue, thanks!

[1/1] scsi: target: core: Add initiatorname to NON_EXISTENT_LUN error
https://git.kernel.org/mkp/scsi/c/5482d56bfedf

--
Martin K. Petersen Oracle Linux Engineering