2020-07-14 22:06:31

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH 1/5] media/media-device.h: drop duplicated word in comment

Delete the doubled word "the" in a comment.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
---
include/media/media-device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200714.orig/include/media/media-device.h
+++ linux-next-20200714/include/media/media-device.h
@@ -128,7 +128,7 @@ struct media_device_ops {
*
* Use-case: find tuner entity connected to the decoder
* entity and check if it is available, and activate the
- * the link between them from @enable_source and deactivate
+ * link between them from @enable_source and deactivate
* from @disable_source.
*
* .. note::


2020-07-14 22:06:37

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH 2/5] media/media-devnode.h: drop duplicated word in comment

Delete the doubled word "the" in a comment.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
---
include/media/media-devnode.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200714.orig/include/media/media-devnode.h
+++ linux-next-20200714/include/media/media-devnode.h
@@ -39,7 +39,7 @@ struct media_device;
* @poll: pointer to the function that implements poll() syscall
* @ioctl: pointer to the function that implements ioctl() syscall
* @compat_ioctl: pointer to the function that will handle 32 bits userspace
- * calls to the the ioctl() syscall on a Kernel compiled with 64 bits.
+ * calls to the ioctl() syscall on a Kernel compiled with 64 bits.
* @open: pointer to the function that implements open() syscall
* @release: pointer to the function that will release the resources allocated
* by the @open function.

2020-07-14 22:06:54

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH 4/5] media/media-entity.h: drop duplicated word in comment

Delete the doubled word "flag" in a comment.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
---
include/media/media-entity.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200714.orig/include/media/media-entity.h
+++ linux-next-20200714/include/media/media-entity.h
@@ -803,7 +803,7 @@ int __media_entity_setup_link(struct med
* @flags: the requested new link flags
*
* The only configurable property is the %MEDIA_LNK_FL_ENABLED link flag
- * flag to enable/disable a link. Links marked with the
+ * to enable/disable a link. Links marked with the
* %MEDIA_LNK_FL_IMMUTABLE link flag can not be enabled or disabled.
*
* When a link is enabled or disabled, the media framework calls the

2020-07-14 22:06:58

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH 3/5] media/dvbdev.h: fix duplicated word in comment

Change the doubled word "the" in a comment to "to the".

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
---
include/media/dvbdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20200714.orig/include/media/dvbdev.h
+++ linux-next-20200714/include/media/dvbdev.h
@@ -385,7 +385,7 @@ struct i2c_client;
* with dvb_module_probe() should use dvb_module_release() to unbind.
*
* Return:
- * On success, return an &struct i2c_client, pointing the the bound
+ * On success, return an &struct i2c_client, pointing to the bound
* I2C device. %NULL otherwise.
*
* .. note::

2020-07-14 22:07:55

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH 5/5] media/v4l2-subdev.h: drop duplicated word in comment

Delete the doubled words "the" in comments.

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
---
include/media/v4l2-subdev.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

--- linux-next-20200714.orig/include/media/v4l2-subdev.h
+++ linux-next-20200714/include/media/v4l2-subdev.h
@@ -566,9 +566,9 @@ struct v4l2_subdev_ir_parameters {
*
* @rx_read: Reads received codes or pulse width data.
* The semantics are similar to a non-blocking read() call.
- * @rx_g_parameters: Get the current operating parameters and state of the
+ * @rx_g_parameters: Get the current operating parameters and state of
* the IR receiver.
- * @rx_s_parameters: Set the current operating parameters and state of the
+ * @rx_s_parameters: Set the current operating parameters and state of
* the IR receiver. It is recommended to call
* [rt]x_g_parameters first to fill out the current state, and only change
* the fields that need to be changed. Upon return, the actual device
@@ -582,9 +582,9 @@ struct v4l2_subdev_ir_parameters {
*
* @tx_write: Writes codes or pulse width data for transmission.
* The semantics are similar to a non-blocking write() call.
- * @tx_g_parameters: Get the current operating parameters and state of the
+ * @tx_g_parameters: Get the current operating parameters and state of
* the IR transmitter.
- * @tx_s_parameters: Set the current operating parameters and state of the
+ * @tx_s_parameters: Set the current operating parameters and state of
* the IR transmitter. It is recommended to call
* [rt]x_g_parameters first to fill out the current state, and only change
* the fields that need to be changed. Upon return, the actual device

2020-07-15 01:24:33

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH 3/5] media/dvbdev.h: fix duplicated word in comment

On Tue, 2020-07-14 at 15:05 -0700, Randy Dunlap wrote:
> Change the doubled word "the" in a comment to "to the".

Hey
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]
> ---
> include/media/dvbdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200714.orig/include/media/dvbdev.h
> +++ linux-next-20200714/include/media/dvbdev.h
> @@ -385,7 +385,7 @@ struct i2c_client;
> * with dvb_module_probe() should use dvb_module_release() to unbind.
> *
> * Return:
> - * On success, return an &struct i2c_client, pointing the the bound
> + * On success, return an &struct i2c_client, pointing to the bound

an &struct reads OK as text, but does not as rst/html

Perhaps this should be:

return the address of the bound &struct i2c_client device
or
return a pointer to the bound &struct i2c_client device

otherwise the html output is

Return

On success, return an struct i2c_client, pointing to the bound
I2C device. NULL otherwise.

and there seem to be too many commas used as well.



2020-07-17 12:00:22

by Kieran Bingham

[permalink] [raw]
Subject: Re: [PATCH 1/5] media/media-device.h: drop duplicated word in comment

On 14/07/2020 23:05, Randy Dunlap wrote:
> Delete the doubled word "the" in a comment.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]

Reviewed-by: Kieran Bingham <[email protected]>

> ---
> include/media/media-device.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200714.orig/include/media/media-device.h
> +++ linux-next-20200714/include/media/media-device.h
> @@ -128,7 +128,7 @@ struct media_device_ops {
> *
> * Use-case: find tuner entity connected to the decoder
> * entity and check if it is available, and activate the
> - * the link between them from @enable_source and deactivate
> + * link between them from @enable_source and deactivate
> * from @disable_source.
> *
> * .. note::
>

2020-07-17 12:00:47

by Kieran Bingham

[permalink] [raw]
Subject: Re: [PATCH 2/5] media/media-devnode.h: drop duplicated word in comment

On 14/07/2020 23:05, Randy Dunlap wrote:
> Delete the doubled word "the" in a comment.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]
> ---
> include/media/media-devnode.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200714.orig/include/media/media-devnode.h
> +++ linux-next-20200714/include/media/media-devnode.h
> @@ -39,7 +39,7 @@ struct media_device;
> * @poll: pointer to the function that implements poll() syscall
> * @ioctl: pointer to the function that implements ioctl() syscall
> * @compat_ioctl: pointer to the function that will handle 32 bits userspace
> - * calls to the the ioctl() syscall on a Kernel compiled with 64 bits.
> + * calls to the ioctl() syscall on a Kernel compiled with 64 bits.
> * @open: pointer to the function that implements open() syscall
> * @release: pointer to the function that will release the resources allocated
> * by the @open function.
>

2020-07-17 12:01:20

by Kieran Bingham

[permalink] [raw]
Subject: Re: [PATCH 4/5] media/media-entity.h: drop duplicated word in comment

On 14/07/2020 23:05, Randy Dunlap wrote:
> Delete the doubled word "flag" in a comment.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]

Reviewed-by: Kieran Bingham <[email protected]>

> ---
> include/media/media-entity.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20200714.orig/include/media/media-entity.h
> +++ linux-next-20200714/include/media/media-entity.h
> @@ -803,7 +803,7 @@ int __media_entity_setup_link(struct med
> * @flags: the requested new link flags
> *
> * The only configurable property is the %MEDIA_LNK_FL_ENABLED link flag
> - * flag to enable/disable a link. Links marked with the
> + * to enable/disable a link. Links marked with the
> * %MEDIA_LNK_FL_IMMUTABLE link flag can not be enabled or disabled.
> *
> * When a link is enabled or disabled, the media framework calls the
>

2020-07-17 12:01:20

by Kieran Bingham

[permalink] [raw]
Subject: Re: [PATCH 5/5] media/v4l2-subdev.h: drop duplicated word in comment

On 14/07/2020 23:05, Randy Dunlap wrote:
> Delete the doubled words "the" in comments.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]

I guess the second instance of the word could have also been removed, to
keep more content on the first line, which fits under 80chars, but I
don't think it really matters.

Reviewed-by: Kieran Bingham <[email protected]>

> ---
> include/media/v4l2-subdev.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> --- linux-next-20200714.orig/include/media/v4l2-subdev.h
> +++ linux-next-20200714/include/media/v4l2-subdev.h
> @@ -566,9 +566,9 @@ struct v4l2_subdev_ir_parameters {
> *
> * @rx_read: Reads received codes or pulse width data.
> * The semantics are similar to a non-blocking read() call.
> - * @rx_g_parameters: Get the current operating parameters and state of the
> + * @rx_g_parameters: Get the current operating parameters and state of
> * the IR receiver.
> - * @rx_s_parameters: Set the current operating parameters and state of the
> + * @rx_s_parameters: Set the current operating parameters and state of
> * the IR receiver. It is recommended to call
> * [rt]x_g_parameters first to fill out the current state, and only change
> * the fields that need to be changed. Upon return, the actual device
> @@ -582,9 +582,9 @@ struct v4l2_subdev_ir_parameters {
> *
> * @tx_write: Writes codes or pulse width data for transmission.
> * The semantics are similar to a non-blocking write() call.
> - * @tx_g_parameters: Get the current operating parameters and state of the
> + * @tx_g_parameters: Get the current operating parameters and state of
> * the IR transmitter.
> - * @tx_s_parameters: Set the current operating parameters and state of the
> + * @tx_s_parameters: Set the current operating parameters and state of
> * the IR transmitter. It is recommended to call
> * [rt]x_g_parameters first to fill out the current state, and only change
> * the fields that need to be changed. Upon return, the actual device
>