2006-01-18 04:58:08

by Aneesh Kumar K.V

[permalink] [raw]
Subject: Add entry.S function name to tag file

How about a patch like the one attached below. I am not sure whether i
got the regular expression correct. But it works for me.

-aneesh


Attachments:
(No filename) (137.00 B)
Makefile.diff (575.00 B)
Download all attachments

2006-01-19 02:42:09

by Zhang Le

[permalink] [raw]
Subject: Re: Add entry.S function name to tag file

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aneesh Kumar wrote:
> How about a patch like the one attached below. I am not sure
> whether i got the regular expression correct. But it works for me.
>
> -aneesh
>
> ----------------------------------------------------------------------
>
>
> diff --git a/Makefile b/Makefile index 252a659..6c8479e 100644 ---
> a/Makefile +++ b/Makefile @@ -1272,7 +1272,7 @@ define cmd_tags
> CTAGSF=`ctags --version | grep -i exuberant >/dev/null && \
> echo "-I __initdata,__exitdata,__acquires,__releases \ -I
> EXPORT_SYMBOL,EXPORT_SYMBOL_GPL \ -
> --extra=+f --c-kinds=+px"`; \ +
> --extra=+f --c-kinds=+px --regex-asm=/ENTRY\(([^)]*)\).*/\1/f/"`;
> \
what's the meaning of "f"
kind-spec?
But `exuberant-ctags --list-kinds` here shows ASM don't have "f" kind

> $(all-sources) | xargs ctags $$CTAGSF -a endef
>


- --
Zhang Le, Robert
Linux Engineer/Trainer

Institute of Thiz Technology Limited
Address: Unit 1004, 10/F, Tower B,
Hunghom Commercial Centre, 37 Ma Tau Wai Road,
To Kwa Wan, Kowloon, Hong Kong
Telephone: (852) 2735 2725
Mobile:(852) 9845 4336
Fax: (852) 2111 0702
URL: http://www.thizgroup.com
Public key: gpg --keyserver pgp.mit.edu --recv-keys 1E4E2973

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFDzvwQvFHICB5OKXMRAun5AJ9R4JxmJHpWDSeMfeWK0uFZrii1IwCgkqPS
PK1yVn5CBm69k5prJXIpllU=
=fMv5
-----END PGP SIGNATURE-----

2006-01-19 03:54:46

by Zhang Le

[permalink] [raw]
Subject: Re: Add entry.S function name to tag file

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aneesh Kumar wrote:
> How about a patch like the one attached below. I am not sure whether i
> got the regular expression correct. But it works for me.
>
> -aneesh
>
> ----------------------------------------------------------------------
>
> diff --git a/Makefile b/Makefile
> index 252a659..6c8479e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1272,7 +1272,7 @@ define cmd_tags
> CTAGSF=`ctags --version | grep -i exuberant >/dev/null && \
> echo "-I __initdata,__exitdata,__acquires,__releases \
> -I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL \
> - --extra=+f --c-kinds=+px"`; \
> + --extra=+f --c-kinds=+px
--regex-asm=/ENTRY\(([^)]*)\).*/\1/f/"`; \
> $(all-sources) | xargs ctags $$CTAGSF -a
> endef
>
In fact, ENTRY()'s are not functions
they are just label's
some are functions
some are variables
no need to add "f" here

the following is just OK
- --regex-asm=/ENTRY\(([^)]*)\).*/\1/"

the only difference between tags file generated from these two
different option
is like this
- -alignment_check arch/i386/kernel/entry.S
/^ENTRY(alignment_check)$/;" r
+alignment_check arch/i386/kernel/entry.S
/^ENTRY(alignment_check)$/;" f

- --
Zhang Le, Robert
Linux Engineer/Trainer

Institute of Thiz Technology Limited
Address: Unit 1004, 10/F, Tower B,
Hunghom Commercial Centre, 37 Ma Tau Wai Road,
To Kwa Wan, Kowloon, Hong Kong
Telephone: (852) 2735 2725
Mobile:(852) 9845 4336
Fax: (852) 2111 0702
URL: http://www.thizgroup.com
Public key: gpg --keyserver pgp.mit.edu --recv-keys 1E4E2973

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFDzw0ZvFHICB5OKXMRAsyGAJ0TeXETc5OxTaovom9YHxzQkcbpyACeLJ58
Ztl/ug1VR4JoNM8nzIwTwyk=
=zQwU
-----END PGP SIGNATURE-----