2022-10-09 02:55:39

by Liu Ying

[permalink] [raw]
Subject: [PATCH] drm/imx: Kconfig: Remove duplicated 'select DRM_KMS_HELPER' line

A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig file
by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"),
so remove it.

Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Liu Ying <[email protected]>
---
drivers/gpu/drm/imx/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
index 975de4ff7313..fd5b2471fdf0 100644
--- a/drivers/gpu/drm/imx/Kconfig
+++ b/drivers/gpu/drm/imx/Kconfig
@@ -4,7 +4,6 @@ config DRM_IMX
select DRM_KMS_HELPER
select VIDEOMODE_HELPERS
select DRM_GEM_DMA_HELPER
- select DRM_KMS_HELPER
depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST)
depends on IMX_IPUV3_CORE
help
--
2.37.1


2022-10-26 07:30:30

by Liu Ying

[permalink] [raw]
Subject: Re: [PATCH] drm/imx: Kconfig: Remove duplicated 'select DRM_KMS_HELPER' line

Hi Philipp,

On Sun, 2022-10-09 at 10:35 +0800, Liu Ying wrote:
> A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig
> file
> by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER
> option"),
> so remove it.
>
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> Signed-off-by: Liu Ying <[email protected]>
> ---
> drivers/gpu/drm/imx/Kconfig | 1 -
> 1 file changed, 1 deletion(-)

If no objections, can you please pick this small fix up through
imx-drm/fixes? Or through drm-misc-fixes?

Regards,
Liu Ying



2022-11-01 14:08:13

by Philipp Zabel

[permalink] [raw]
Subject: Re: [PATCH] drm/imx: Kconfig: Remove duplicated 'select DRM_KMS_HELPER' line

On So, 2022-10-09 at 10:35 +0800, Liu Ying wrote:
> A duplicated line 'select DRM_KMS_HELPER' was introduced in Kconfig file
> by commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option"),
> so remove it.
>
> Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
> Signed-off-by: Liu Ying <[email protected]>
> ---
>  drivers/gpu/drm/imx/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imx/Kconfig b/drivers/gpu/drm/imx/Kconfig
> index 975de4ff7313..fd5b2471fdf0 100644
> --- a/drivers/gpu/drm/imx/Kconfig
> +++ b/drivers/gpu/drm/imx/Kconfig
> @@ -4,7 +4,6 @@ config DRM_IMX
>   select DRM_KMS_HELPER
>   select VIDEOMODE_HELPERS
>   select DRM_GEM_DMA_HELPER
> - select DRM_KMS_HELPER
>   depends on DRM && (ARCH_MXC || ARCH_MULTIPLATFORM || COMPILE_TEST)
>   depends on IMX_IPUV3_CORE
>   help

Reviewed-by: Philipp Zabel <[email protected]>

and pushed to drm-misc-fixes.

regards
Philipp