2023-02-15 01:22:01

by Yang Li

Subject: [PATCH -next] mtd: ubi: Simplify bool conversion

./drivers/mtd/ubi/build.c:1261:33-38: WARNING: conversion to bool not needed here

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4061
Signed-off-by: Yang Li <[email protected]>
---
drivers/mtd/ubi/build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 0904eb40c95f..e9c153b7c471 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -1258,7 +1258,7 @@ static int __init ubi_init(void)
mutex_lock(&ubi_devices_mutex);
err = ubi_attach_mtd_dev(mtd, p->ubi_num,
p->vid_hdr_offs, p->max_beb_per1024,
- p->enable_fm == 0 ? true : false);
+ p->enable_fm == 0);
mutex_unlock(&ubi_devices_mutex);
if (err < 0) {
pr_err("UBI error: cannot attach mtd%d\n",
--
2.20.1.7.g153144c

2023-03-20 02:28:53

by Zhihao Cheng

Subject: Re: [PATCH -next] mtd: ubi: Simplify bool conversion

?? 2023/2/15 9:21, Yang Li д??:
> ./drivers/mtd/ubi/build.c:1261:33-38: WARNING: conversion to bool not needed here
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4061
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/mtd/ubi/build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
> index 0904eb40c95f..e9c153b7c471 100644
> --- a/drivers/mtd/ubi/build.c
> +++ b/drivers/mtd/ubi/build.c
> @@ -1258,7 +1258,7 @@ static int __init ubi_init(void)
> mutex_lock(&ubi_devices_mutex);
> err = ubi_attach_mtd_dev(mtd, p->ubi_num,
> p->vid_hdr_offs, p->max_beb_per1024,
> - p->enable_fm == 0 ? true : false);
> + p->enable_fm == 0);
> mutex_unlock(&ubi_devices_mutex);
> if (err < 0) {
> pr_err("UBI error: cannot attach mtd%d\n",
>

Looks good.

Reviewed-by: Zhihao Cheng <[email protected]>