2018-01-24 01:49:50

by Gustavo A. R. Silva

Subject: [PATCH] macintosh/ams-input: Use true and false for boolean values

Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/macintosh/ams/ams-input.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/macintosh/ams/ams-input.c b/drivers/macintosh/ams/ams-input.c
index 2edae7d..fe248f6 100644
--- a/drivers/macintosh/ams/ams-input.c
+++ b/drivers/macintosh/ams/ams-input.c
@@ -91,7 +91,7 @@ static int ams_input_enable(void)
return error;
}

- joystick = 1;
+ joystick = true;

return 0;
}
@@ -104,7 +104,7 @@ static void ams_input_disable(void)
ams_info.idev = NULL;
}

- joystick = 0;
+ joystick = false;
}

static ssize_t ams_input_show_joystick(struct device *dev,
--
2.7.4

2018-01-24 01:56:20

by Michael Hanselmann

Subject: Re: [PATCH] macintosh/ams-input: Use true and false for boolean values

On 24.01.2018 02:48, Gustavo A. R. Silva wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Reviewed-by: Michael Hanselmann <[email protected]>

2018-01-29 04:15:23

by Michael Ellerman

Subject: Re: macintosh/ams-input: Use true and false for boolean values

On Wed, 2018-01-24 at 01:48:46 UTC, "Gustavo A. R. Silva" wrote:
> Assign true or false to boolean variables instead of an integer value.
>
> This issue was detected with the help of Coccinelle
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> Reviewed-by: Michael Hanselmann <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/516c32f64f144721ca05b881737e44

cheers