2020-05-11 11:23:36

by Xiaoming Ni

Subject: [PATCH] trace: Remove duplicate semicolons at the end of line

Remove duplicate semicolons at the end of line in
include/trace/events/iocost.h

Signed-off-by: Xiaoming Ni <[email protected]>
---
include/trace/events/iocost.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
index 7ecaa65b..91297eb 100644
--- a/include/trace/events/iocost.h
+++ b/include/trace/events/iocost.h
@@ -152,7 +152,7 @@

TP_fast_assign(
__assign_str(devname, ioc_name(ioc));
- __entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
+ __entry->old_vrate = atomic64_read(&ioc->vtime_rate);
__entry->new_vrate = new_vrate;
__entry->busy_level = ioc->busy_level;
__entry->read_missed_ppm = (*missed_ppm)[READ];
--
1.8.5.6

2020-05-11 14:28:40

by Tejun Heo

Subject: Re: [PATCH] trace: Remove duplicate semicolons at the end of line

On Mon, May 11, 2020 at 07:21:02PM +0800, Xiaoming Ni wrote:
> Remove duplicate semicolons at the end of line in
> include/trace/events/iocost.h
>
> Signed-off-by: Xiaoming Ni <[email protected]>

Acked-by: Tejun Heo <[email protected]>

iocost changes normally goes through the block tree. Can you please resend
with Jens Axboe <[email protected]> and [email protected] added to
the cc list?

Thanks.

--
tejun

2020-05-11 20:42:03

by Steven Rostedt

Subject: Re: [PATCH] trace: Remove duplicate semicolons at the end of line

On Mon, 11 May 2020 19:21:02 +0800
Xiaoming Ni <[email protected]> wrote:

> Remove duplicate semicolons at the end of line in
> include/trace/events/iocost.h

This looks like it should go through Jens's tree.

-- Steve

>
> Signed-off-by: Xiaoming Ni <[email protected]>
> ---
> include/trace/events/iocost.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> index 7ecaa65b..91297eb 100644
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
> @@ -152,7 +152,7 @@
>
> TP_fast_assign(
> __assign_str(devname, ioc_name(ioc));
> - __entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
> + __entry->old_vrate = atomic64_read(&ioc->vtime_rate);
> __entry->new_vrate = new_vrate;
> __entry->busy_level = ioc->busy_level;
> __entry->read_missed_ppm = (*missed_ppm)[READ];

2020-05-11 20:44:15

by Jens Axboe

Subject: Re: [PATCH] trace: Remove duplicate semicolons at the end of line

On 5/11/20 2:40 PM, Steven Rostedt wrote:
> On Mon, 11 May 2020 19:21:02 +0800
> Xiaoming Ni <[email protected]> wrote:
>
>> Remove duplicate semicolons at the end of line in
>> include/trace/events/iocost.h
>
> This looks like it should go through Jens's tree.

I'll add it for 5.8, thanks.

--
Jens Axboe