[CCing Nícolas]
On 07.03.24 19:10, Chris Bainbridge wrote:
First off: many thx for this, much appreciated!
> Append a ':' character to the first usage of "#regzbot introduced".
FWIW, that is obvious and not needed here; but having it in the subject
would be good. The subject also does not really match the expected
style. But let's ignore that for now due the aspect mentioned below.
> According to the regzbot documentation, the ':' suffix is the correct
> format, and, even if not strictly necessary, it is good to be
> consistent.
Sadly a slightly tricky situation developed coincidentally: Nícolas not
even 24 hours later send a patch that fixes this as well, but does so in
a related document as well, which is wise:
https://lore.kernel.org/all/[email protected]/
Which leads to the question: how much do you care that you patch makes
it in? If you would like to have a fresh commit in the kernel (which is
totally valid thing to want!) we definitely could improve your
submission and then adjust Nícolas changes on top of it -- but if you
don't care at all we could just directly take Nícolas patch.
Ciao, Thorsten
On Sun, Mar 10, 2024 at 08:57:55AM +0100, Thorsten Leemhuis wrote:
> Which leads to the question: how much do you care that you patch makes
> it in? If you would like to have a fresh commit in the kernel (which is
> totally valid thing to want!) we definitely could improve your
> submission and then adjust N?colas changes on top of it -- but if you
> don't care at all we could just directly take N?colas patch.
I don't care - just take the other patch. But please fix the multiple
incorrect spellings of colon ('collon') first.
On 10.03.24 11:45, Chris Bainbridge wrote:
> On Sun, Mar 10, 2024 at 08:57:55AM +0100, Thorsten Leemhuis wrote:
>> Which leads to the question: how much do you care that you patch makes
>> it in? If you would like to have a fresh commit in the kernel (which is
>> totally valid thing to want!) we definitely could improve your
>> submission and then adjust Nícolas changes on top of it -- but if you
>> don't care at all we could just directly take Nícolas patch.
>
> I don't care - just take the other patch.
Okay, many thx for this!
> But please fix the multiple
> incorrect spellings of colon ('collon') first.
:-D Will bring this up when reviewing (but I guess I only will get
around to that tomorrow).
Thx again!
Ciao, Thorsten
On Sun, Mar 10, 2024 at 10:45:35AM +0000, Chris Bainbridge wrote:
> On Sun, Mar 10, 2024 at 08:57:55AM +0100, Thorsten Leemhuis wrote:
> > Which leads to the question: how much do you care that you patch makes
> > it in? If you would like to have a fresh commit in the kernel (which is
> > totally valid thing to want!) we definitely could improve your
> > submission and then adjust N?colas changes on top of it -- but if you
> > don't care at all we could just directly take N?colas patch.
>
> I don't care - just take the other patch. But please fix the multiple
> incorrect spellings of colon ('collon') first.
Oh wow, I looked it up before writing and was confident that was the right
spelling... Thanks for pointing it out, will fix in v2 after Thorsten gives any
other feedback he might have.
Thanks,
N?colas