2005-11-30 17:18:51

by Franck Bui-Huu

[permalink] [raw]
Subject: [PATCH] Add MIPS dependency for dm9000 driver

The attached patch adds MIPS dependency for dm9000 ethernet
controller. Indeed this controller is used by some embedded platforms
based on MIPS CPUs.

Signed-Off-By: Franck Bui-Huu <[email protected]>
---
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f15f909..1b00169 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -856,7 +856,7 @@ config SMC9194

config DM9000
tristate "DM9000 support"
- depends on ARM && NET_ETHERNET
+ depends on (ARM || MIPS) && NET_ETHERNET
select CRC32
select MII
---help---


2005-11-30 21:26:43

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] Add MIPS dependency for dm9000 driver

Franck <[email protected]> wrote:
>
> The attached patch adds MIPS dependency for dm9000 ethernet
> controller. Indeed this controller is used by some embedded platforms
> based on MIPS CPUs.
>
> Signed-Off-By: Franck Bui-Huu <[email protected]>
> ---
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f15f909..1b00169 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -856,7 +856,7 @@ config SMC9194
>
> config DM9000
> tristate "DM9000 support"
> - depends on ARM && NET_ETHERNET
> + depends on (ARM || MIPS) && NET_ETHERNET
> select CRC32
> select MII

Is there any reason why we cannot enable this driver on all architectures?

It's moderately important for quality and maintainability reasons that it
be included in the x86 build, at least..

2005-12-01 08:06:00

by Franck Bui-Huu

[permalink] [raw]
Subject: Re: [PATCH] Add MIPS dependency for dm9000 driver

Hi Andrew

2005/11/30, Andrew Morton <[email protected]>:
> Franck <[email protected]> wrote:
> >
> > The attached patch adds MIPS dependency for dm9000 ethernet
> > controller. Indeed this controller is used by some embedded platforms
> > based on MIPS CPUs.
> >
>
> Is there any reason why we cannot enable this driver on all architectures?
>
> It's moderately important for quality and maintainability reasons that it
> be included in the x86 build, at least..
>

Actually there's a discussion about that. I previously sent a RFC
(subject is "[NET] Remove ARM dependency for dm9000 driver") for that.
Now some people are reacting so we should wait for the last words
before applying something.

thanks
--
Franck