2021-03-08 08:47:04

by Zhu, Lingshan

Subject: [PATCH V2 4/4] vDPA/ifcvf: remove the version number string

This commit removes the version number string, using kernel
version is enough.

Signed-off-by: Zhu Lingshan <[email protected]>
---
drivers/vdpa/ifcvf/ifcvf_main.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
index fd5befc5cbcc..c34e1eec6b6c 100644
--- a/drivers/vdpa/ifcvf/ifcvf_main.c
+++ b/drivers/vdpa/ifcvf/ifcvf_main.c
@@ -14,7 +14,6 @@
#include <linux/sysfs.h>
#include "ifcvf_base.h"

-#define VERSION_STRING "0.1"
#define DRIVER_AUTHOR "Intel Corporation"
#define IFCVF_DRIVER_NAME "ifcvf"

@@ -503,4 +502,3 @@ static struct pci_driver ifcvf_driver = {
module_pci_driver(ifcvf_driver);

MODULE_LICENSE("GPL v2");
-MODULE_VERSION(VERSION_STRING);
--
2.27.0

2021-03-08 16:05:54

by Leon Romanovsky

Subject: Re: [PATCH V2 4/4] vDPA/ifcvf: remove the version number string

On Mon, Mar 08, 2021 at 04:35:25PM +0800, Zhu Lingshan wrote:
> This commit removes the version number string, using kernel
> version is enough.
>
> Signed-off-by: Zhu Lingshan <[email protected]>
> ---
> drivers/vdpa/ifcvf/ifcvf_main.c | 2 --
> 1 file changed, 2 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <[email protected]>

2021-03-09 02:27:25

by Jason Wang

Subject: Re: [PATCH V2 4/4] vDPA/ifcvf: remove the version number string

On 2021/3/8 4:35 下午, Zhu Lingshan wrote:
> This commit removes the version number string, using kernel
> version is enough.
>
> Signed-off-by: Zhu Lingshan <[email protected]>
> ---


Acked-by: Jason Wang <[email protected]>


> drivers/vdpa/ifcvf/ifcvf_main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c
> index fd5befc5cbcc..c34e1eec6b6c 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_main.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c
> @@ -14,7 +14,6 @@
> #include <linux/sysfs.h>
> #include "ifcvf_base.h"
>
> -#define VERSION_STRING "0.1"
> #define DRIVER_AUTHOR "Intel Corporation"
> #define IFCVF_DRIVER_NAME "ifcvf"
>
> @@ -503,4 +502,3 @@ static struct pci_driver ifcvf_driver = {
> module_pci_driver(ifcvf_driver);
>
> MODULE_LICENSE("GPL v2");
> -MODULE_VERSION(VERSION_STRING);