2024-02-17 20:14:05

by Ricardo B. Marliere

Subject: [PATCH 02/12] net: dsa: constify the struct device_type usage

Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
core can properly handle constant struct device_type. Move the dsa_type
variable to be a constant structure as well, placing it into read-only
memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
net/dsa/user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/dsa/user.c b/net/dsa/user.c
index 5d666dfb317d..4d53c76a9840 100644
--- a/net/dsa/user.c
+++ b/net/dsa/user.c
@@ -2429,7 +2429,7 @@ static const struct net_device_ops dsa_user_netdev_ops = {
.ndo_fill_forward_path = dsa_user_fill_forward_path,
};

-static struct device_type dsa_type = {
+static const struct device_type dsa_type = {
.name = "dsa",
};


--
2.43.0

2024-02-18 21:47:37

by Florian Fainelli

Subject: Re: [PATCH 02/12] net: dsa: constify the struct device_type usage

On 2/17/2024 12:13 PM, Ricardo B. Marliere wrote:
> Since commit aed65af1cc2f ("drivers: make device_type const"), the driver
> core can properly handle constant struct device_type. Move the dsa_type
> variable to be a constant structure as well, placing it into read-only
> memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian