2023-07-26 20:59:59

by Arnd Bergmann

Subject: [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf_read static

From: Arnd Bergmann <[email protected]>

The global function triggers a warning because of the missing prototype

drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)

There are no other references to this, so just make it static.

Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
Reviewed-by: Sergey Shtylyov <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
---
v2: fix changelog text
---
drivers/ata/pata_ns87415.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/pata_ns87415.c b/drivers/ata/pata_ns87415.c
index d60e1f69d7b02..c697219a61a2d 100644
--- a/drivers/ata/pata_ns87415.c
+++ b/drivers/ata/pata_ns87415.c
@@ -260,7 +260,7 @@ static u8 ns87560_check_status(struct ata_port *ap)
* LOCKING:
* Inherited from caller.
*/
-void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+static void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
{
struct ata_ioports *ioaddr = &ap->ioaddr;

--
2.39.2

2023-07-27 00:03:52

by Damien Le Moal

Subject: Re: [PATCH] [v2] ata: pata_ns87415: mark ns87560_tf_read static

On 7/27/23 05:33, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The global function triggers a warning because of the missing prototype
>
> drivers/ata/pata_ns87415.c:263:6: warning: no previous prototype for 'ns87560_tf_read' [-Wmissing-prototypes]
> 263 | void ns87560_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
>
> There are no other references to this, so just make it static.
>
> Fixes: c4b5b7b6c4423 ("pata_ns87415: Initial cut at 87415/87560 IDE support")
> Reviewed-by: Sergey Shtylyov <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>

Applied to for-6.5-fixes. Thanks !


--
Damien Le Moal
Western Digital Research