2019-04-01 05:10:56

by Anson Huang

Subject: [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/gpio/gpio-mxc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index e86e61d..b281358 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -411,7 +411,6 @@ static int mxc_gpio_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
struct mxc_gpio_port *port;
- struct resource *iores;
int irq_base;
int err;

@@ -423,8 +422,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)

port->dev = &pdev->dev;

- iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- port->base = devm_ioremap_resource(&pdev->dev, iores);
+ port->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(port->base))
return PTR_ERR(port->base);

--
2.7.4

2019-04-01 08:09:24

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code

pon., 1 kwi 2019 o 07:09 Anson Huang <[email protected]> napisał(a):
>
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <[email protected]>
> ---
> drivers/gpio/gpio-mxc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index e86e61d..b281358 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -411,7 +411,6 @@ static int mxc_gpio_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> struct mxc_gpio_port *port;
> - struct resource *iores;
> int irq_base;
> int err;
>
> @@ -423,8 +422,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
>
> port->dev = &pdev->dev;
>
> - iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - port->base = devm_ioremap_resource(&pdev->dev, iores);
> + port->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(port->base))
> return PTR_ERR(port->base);
>
> --
> 2.7.4
>

Patch is trivial, so applied right away. Thanks!

Bart

2019-04-01 08:12:24

by Mukesh Ojha

Subject: Re: [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code

On 4/1/2019 10:39 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> drivers/gpio/gpio-mxc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index e86e61d..b281358 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -411,7 +411,6 @@ static int mxc_gpio_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> struct mxc_gpio_port *port;
> - struct resource *iores;
> int irq_base;
> int err;
>
> @@ -423,8 +422,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
>
> port->dev = &pdev->dev;
>
> - iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - port->base = devm_ioremap_resource(&pdev->dev, iores);
> + port->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(port->base))
> return PTR_ERR(port->base);
>