2021-01-28 00:24:03

by Alexander Lobakin

Subject: [PATCH v2 net-next 1/4] mm: constify page_is_pfmemalloc() argument

The function only tests for page->index, so its argument should be
const.

Signed-off-by: Alexander Lobakin <[email protected]>
---
include/linux/mm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index ecdf8a8cd6ae..078633d43af9 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1584,7 +1584,7 @@ struct address_space *page_mapping_file(struct page *page);
* ALLOC_NO_WATERMARKS and the low watermark was not
* met implying that the system is under some pressure.
*/
-static inline bool page_is_pfmemalloc(struct page *page)
+static inline bool page_is_pfmemalloc(const struct page *page)
{
/*
* Page index cannot be this large so this must be
--
2.30.0

2021-01-28 22:48:14

by David Rientjes

Subject: Re: [PATCH v2 net-next 1/4] mm: constify page_is_pfmemalloc() argument

On Wed, 27 Jan 2021, Alexander Lobakin wrote:

> The function only tests for page->index, so its argument should be
> const.
>
> Signed-off-by: Alexander Lobakin <[email protected]>

Acked-by: David Rientjes <[email protected]>

2021-01-30 10:03:36

by Jakub Kicinski

Subject: Re: [PATCH v2 net-next 1/4] mm: constify page_is_pfmemalloc() argument

On Wed, 27 Jan 2021 20:11:01 +0000 Alexander Lobakin wrote:
> The function only tests for page->index, so its argument should be
> const.
>
> Signed-off-by: Alexander Lobakin <[email protected]>
> ---
> include/linux/mm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index ecdf8a8cd6ae..078633d43af9 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1584,7 +1584,7 @@ struct address_space *page_mapping_file(struct page *page);
> * ALLOC_NO_WATERMARKS and the low watermark was not
> * met implying that the system is under some pressure.
> */
> -static inline bool page_is_pfmemalloc(struct page *page)
> +static inline bool page_is_pfmemalloc(const struct page *page)
> {
> /*
> * Page index cannot be this large so this must be

No objections for this going via net-next?