2024-01-08 18:22:17

by Breno Leitao

Subject: [PATCH net-next 10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer

W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
Add descriptions to the LynxI PCS MediaTek's SoC.

Signed-off-by: Breno Leitao <[email protected]>
---
drivers/net/pcs/pcs-mtk-lynxi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/pcs/pcs-mtk-lynxi.c b/drivers/net/pcs/pcs-mtk-lynxi.c
index 8501dd365279..4f63abe638c4 100644
--- a/drivers/net/pcs/pcs-mtk-lynxi.c
+++ b/drivers/net/pcs/pcs-mtk-lynxi.c
@@ -303,4 +303,5 @@ void mtk_pcs_lynxi_destroy(struct phylink_pcs *pcs)
}
EXPORT_SYMBOL(mtk_pcs_lynxi_destroy);

+MODULE_DESCRIPTION("MediaTek SGMII library for LynxI");
MODULE_LICENSE("GPL");
--
2.39.3

2024-01-08 19:22:07

by Andrew Lunn

Subject: Re: [PATCH net-next 10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer

On Mon, Jan 08, 2024 at 10:16:10AM -0800, Breno Leitao wrote:
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the LynxI PCS MediaTek's SoC.

Does pcs-lynx.c also have this issue? It can be built at a module.

Andrew

2024-01-10 11:53:06

by Breno Leitao

Subject: Re: [PATCH net-next 10/10] net: fill in MODULE_DESCRIPTION()s for PCS Layer

On Mon, Jan 08, 2024 at 08:21:03PM +0100, Andrew Lunn wrote:
> On Mon, Jan 08, 2024 at 10:16:10AM -0800, Breno Leitao wrote:
> > W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> > Add descriptions to the LynxI PCS MediaTek's SoC.
>
> Does pcs-lynx.c also have this issue? It can be built at a module.

Absolutely. I can see the warning in pcs-lynx and pcs-pts.

WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/pcs/pcs_xpcs.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/net/pcs/pcs-lynx.o