Borislav Petkov writes:
> On Sat, May 03, 2014 at 07:59:22PM +0200, Peter Feuerer wrote:
>> added following new models:
>> * Aspire 5755G
>> * AO521
>> * AO751h
>> * Aspire One 753
>> * Extensa 5420
>> * Aspire 5315
>> * Aspire 5739G
>> * TravelMate TM8573T
>>
>> Cc: Andrew Morton <[email protected]>
>> Cc: Andreas Mohr <[email protected]>
>> Cc: Borislav Petkov <[email protected]>
>> Signed-off-by: Peter Feuerer <[email protected]>
>
> Acked-by: Borislav Petkov <[email protected]>
>
>> ---
>> drivers/platform/x86/acerhdf.c | 25 ++++++++++++++++++++++++-
>> 1 file changed, 24 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
>> index dd63e93..176edbd 100644
>> --- a/drivers/platform/x86/acerhdf.c
>> +++ b/drivers/platform/x86/acerhdf.c
>> @@ -50,7 +50,7 @@
>> */
>> #undef START_IN_KERNEL_MODE
>>
>> -#define DRV_VER "0.5.29"
>> +#define DRV_VER "0.5.30"
>
> What's the logic here, increment second minor version number after each
> change?
Everytime I send out a modified version of acerhdf.c to someone in the
internet for trying out some changes, I increment the second minor version
number. And from time to time I push things to Mainline, then I need to
catch up with the numbering ;)
The major 0 is just from the ages, when all cool projects used to have a
0 in front.
Maybe it would be a good idea to go for 1.0 when I implemented a better
handling for the huge bios table.
--
--peter;
On Fri, Jul 18, 2014 at 06:06:53PM +0200, Peter Feuerer wrote:
> Everytime I send out a modified version of acerhdf.c to someone in the
> internet for trying out some changes, I increment the second minor
> version number. And from time to time I push things to Mainline, then
> I need to catch up with the numbering ;)
Right, that's a good way to know which version people are testing when
you're staring at dmesg.
> The major 0 is just from the ages, when all cool projects used to have a 0
> in front.
>
> Maybe it would be a good idea to go for 1.0 when I implemented a better
> handling for the huge bios table.
Probably. You could at least increment it to 0.6 when you switch to the
bang-bang governor :-)
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--