2016-03-20 15:58:44

by Parth Sane

Subject: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings

*** BLURB HERE ***

Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl9712: Fixed FSF address warning in ethernet.h
staging: rtl9712: Fixed FSF address warning in hal_init.c
staging: rtl9712: Fixed FSF address warning in ieee80211.c

drivers/staging/rtl8712/basic_types.h | 4 ----
drivers/staging/rtl8712/drv_types.h | 4 ----
drivers/staging/rtl8712/ethernet.h | 4 ----
drivers/staging/rtl8712/hal_init.c | 4 ----
drivers/staging/rtl8712/ieee80211.c | 4 ----
5 files changed, 20 deletions(-)

--
1.9.1

2016-03-20 15:58:58

by Parth Sane

Subject: [PATCH 2/5] staging: rtl8712: Fixed FSF address warning in drv_types.h

Signed-off-by: Parth Sane <[email protected]>
---
drivers/staging/rtl8712/drv_types.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8712/drv_types.h b/drivers/staging/rtl8712/drv_types.h
index 29e47e1..ae79047 100644
--- a/drivers/staging/rtl8712/drv_types.h
+++ b/drivers/staging/rtl8712/drv_types.h
@@ -11,10 +11,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
* Modifications for inclusion into the Linux staging tree are
* Copyright(c) 2010 Larry Finger. All rights reserved.
*
--
1.9.1

2016-03-20 15:59:14

by Parth Sane

Subject: [PATCH 3/5] staging: rtl9712: Fixed FSF address warning in ethernet.h

Signed-off-by: Parth Sane <[email protected]>
---
drivers/staging/rtl8712/ethernet.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8712/ethernet.h b/drivers/staging/rtl8712/ethernet.h
index fad173f..039da36 100644
--- a/drivers/staging/rtl8712/ethernet.h
+++ b/drivers/staging/rtl8712/ethernet.h
@@ -11,10 +11,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
* Modifications for inclusion into the Linux staging tree are
* Copyright(c) 2010 Larry Finger. All rights reserved.
*
--
1.9.1

2016-03-20 15:59:24

by Parth Sane

Subject: [PATCH 1/5] staging: rtl8712: Fixed FSF address warning in basic_types.h

Signed-off-by: Parth Sane <[email protected]>
---
drivers/staging/rtl8712/basic_types.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8712/basic_types.h b/drivers/staging/rtl8712/basic_types.h
index 7561bed..f5c0231 100644
--- a/drivers/staging/rtl8712/basic_types.h
+++ b/drivers/staging/rtl8712/basic_types.h
@@ -11,10 +11,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
* Modifications for inclusion into the Linux staging tree are
* Copyright(c) 2010 Larry Finger. All rights reserved.
*
--
1.9.1

2016-03-20 16:00:27

by Parth Sane

Subject: [PATCH 5/5] staging: rtl9712: Fixed FSF address warning in ieee80211.c

Signed-off-by: Parth Sane <[email protected]>
---
drivers/staging/rtl8712/ieee80211.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
index d13b4d5..8918654 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging/rtl8712/ieee80211.c
@@ -13,10 +13,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
* Modifications for inclusion into the Linux staging tree are
* Copyright(c) 2010 Larry Finger. All rights reserved.
*
--
1.9.1

2016-03-20 16:01:15

by Parth Sane

Subject: [PATCH 4/5] staging: rtl9712: Fixed FSF address warning in hal_init.c

Signed-off-by: Parth Sane <[email protected]>
---
drivers/staging/rtl8712/hal_init.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
index 17d2b5f..afa7fe78 100644
--- a/drivers/staging/rtl8712/hal_init.c
+++ b/drivers/staging/rtl8712/hal_init.c
@@ -13,10 +13,6 @@
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
* more details.
*
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
* Modifications for inclusion into the Linux staging tree are
* Copyright(c) 2010 Larry Finger. All rights reserved.
*
--
1.9.1

2016-03-20 17:36:09

by Roger H Newell

Subject: Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings

On Sun, Mar 20, 2016 at 1:28 PM, Parth Sane <[email protected]> wrote:
> *** BLURB HERE ***
>
> Parth Sane (5):
> staging: rtl8712: Fixed FSF address warning in basic_types.h
> staging: rtl8712: Fixed FSF address warning in drv_types.h
> staging: rtl9712: Fixed FSF address warning in ethernet.h
> staging: rtl9712: Fixed FSF address warning in hal_init.c
> staging: rtl9712: Fixed FSF address warning in ieee80211.c
>
> drivers/staging/rtl8712/basic_types.h | 4 ----
> drivers/staging/rtl8712/drv_types.h | 4 ----
> drivers/staging/rtl8712/ethernet.h | 4 ----
> drivers/staging/rtl8712/hal_init.c | 4 ----
> drivers/staging/rtl8712/ieee80211.c | 4 ----
> 5 files changed, 20 deletions(-)
>
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

It looks like all the patches in this set do not contain a commit log
in the body. It's up to the maintainer but I'm fairly certain they
won't be accepted without a body.


On Sun, Mar 20, 2016 at 1:32 PM, Parth Sane <[email protected]> wrote:
> Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style.
>
> Parth Sane (5):
> staging: rtl8712: Fixed FSF address warning in basic_types.h
> staging: rtl8712: Fixed FSF address warning in drv_types.h
> staging: rtl9712: Fixed FSF address warning in ethernet.h
> staging: rtl9712: Fixed FSF address warning in hal_init.c
> staging: rtl9712: Fixed FSF address warning in ieee80211.c
>
> drivers/staging/rtl8712/basic_types.h | 4 ----
> drivers/staging/rtl8712/drv_types.h | 4 ----
> drivers/staging/rtl8712/ethernet.h | 4 ----
> drivers/staging/rtl8712/hal_init.c | 4 ----
> drivers/staging/rtl8712/ieee80211.c | 4 ----
> 5 files changed, 20 deletions(-)
>
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

2016-03-20 17:42:51

by Parth Sane

Subject: Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings

> Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style.
>
> Parth Sane (5):
> staging: rtl8712: Fixed FSF address warning in basic_types.h
> staging: rtl8712: Fixed FSF address warning in drv_types.h
> staging: rtl9712: Fixed FSF address warning in ethernet.h
> staging: rtl9712: Fixed FSF address warning in hal_init.c
> staging: rtl9712: Fixed FSF address warning in ieee80211.c
>
> drivers/staging/rtl8712/basic_types.h | 4 ----
> drivers/staging/rtl8712/drv_types.h | 4 ----
> drivers/staging/rtl8712/ethernet.h | 4 ----
> drivers/staging/rtl8712/hal_init.c | 4 ----
> drivers/staging/rtl8712/ieee80211.c | 4 ----
> 5 files changed, 20 deletions(-)
>
> --
> 1.9.1
Hi,
The thing is all these patches are related and have a cover letter explaining changes. But this seems to be a trivial change which is self explanatory.
This should possibly suffice. What do you think?
Regards,
Parth Sane

Attachments:

2016-03-20 23:43:02

by Joshua Clayton

Subject: Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings

On Sunday, March 20, 2016 11:12:32 PM Parth Sane wrote:
> > Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style.
> >
> > Parth Sane (5):
> > staging: rtl8712: Fixed FSF address warning in basic_types.h
> > staging: rtl8712: Fixed FSF address warning in drv_types.h
> > staging: rtl9712: Fixed FSF address warning in ethernet.h
> > staging: rtl9712: Fixed FSF address warning in hal_init.c
> > staging: rtl9712: Fixed FSF address warning in ieee80211.c
> >
> > drivers/staging/rtl8712/basic_types.h | 4 ----
> > drivers/staging/rtl8712/drv_types.h | 4 ----
> > drivers/staging/rtl8712/ethernet.h | 4 ----
> > drivers/staging/rtl8712/hal_init.c | 4 ----
> > drivers/staging/rtl8712/ieee80211.c | 4 ----
> > 5 files changed, 20 deletions(-)
> >
> > --
> > 1.9.1
> Hi,
> The thing is all these patches are related and have a cover letter explaining changes. But this seems to be a trivial change which is self explanatory.
> This should possibly suffice. What do you think?
> Regards,
> Parth Sane
The cover letter does not end up in the repository.
A cover letter can be helpful, but is not required.
You MUST, however add a descriptive commit message to
each patch for them to be accepted into the kernel.
See Documentation/SubmittingPatches in the kernel sources.

2016-03-21 21:27:06

by Greg Kroah-Hartman

Subject: Re: [PATCH 0/5] staging: rtl8712: Fixed Multiple FSF address checkpatch warnings

On Sun, Mar 20, 2016 at 03:59:09PM +0000, Parth Sane wrote:
> *** BLURB HERE ***

You forgot to fill this out :(

>
> Parth Sane (5):
> staging: rtl8712: Fixed FSF address warning in basic_types.h
> staging: rtl8712: Fixed FSF address warning in drv_types.h
> staging: rtl9712: Fixed FSF address warning in ethernet.h
> staging: rtl9712: Fixed FSF address warning in hal_init.c
> staging: rtl9712: Fixed FSF address warning in ieee80211.c

Your subject lines are refering to an unknown driver :(

2016-03-21 21:27:21

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/5] staging: rtl8712: Fixed FSF address warning in basic_types.h

On Sun, Mar 20, 2016 at 03:58:28PM +0000, Parth Sane wrote:
> Signed-off-by: Parth Sane <[email protected]>

I can't take patches with no changelog text :(