2017-11-20 21:54:46

by Marcin Ciupak

[permalink] [raw]
Subject: [PATCH 0/2] staging: pi433: fix logging and naming issues

These patches fix messages logging and device naming issues when probing
for new radio module.

Those two changes are send as one patchset since both modify the same
part of code (second patch depends on first one)


Marcin Ciupak (2):
staging: pi433: fix (NULL device *) in log message
staging: pi433: fix naming when more than one radio is used

drivers/staging/pi433/pi433_if.c | 30 ++++++++++++++++--------------
1 file changed, 16 insertions(+), 14 deletions(-)

--
2.15.0


From 1584612218158014713@xxx Mon Nov 20 18:52:53 +0000 2017
X-GM-THRID: 1584064321307856567
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread


2017-11-20 21:59:19

by Marcin Ciupak

[permalink] [raw]
Subject: [PATCH 2/2] staging: pi433: fix naming when more than one radio is used

When using more than one hardware radio module pi433_probe fails as the
same name is used for all modules. Create unique name by adding minor
number to the device name.

Signed-off-by: Marcin Ciupak <[email protected]>
---
drivers/staging/pi433/pi433_if.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index bc17676169cb..7a3e3101c483 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -1172,7 +1172,8 @@ static int pi433_probe(struct spi_device *spi)
&spi->dev,
device->devt,
device,
- "pi433");
+ "pi433.%d",
+ device->minor);
if (IS_ERR(device->dev)) {
pr_err("pi433: device register failed\n");
retval = PTR_ERR(device->dev);
@@ -1188,7 +1189,8 @@ static int pi433_probe(struct spi_device *spi)
/* start tx thread */
device->tx_task_struct = kthread_run(pi433_tx_thread,
device,
- "pi433_tx_task");
+ "pi433.%d_tx_task",
+ device->minor);
if (IS_ERR(device->tx_task_struct)) {
dev_dbg(device->dev, "start of send thread failed");
goto send_thread_failed;
--
2.15.0


From 1584738398853126047@xxx Wed Nov 22 04:18:29 +0000 2017
X-GM-THRID: 1584648462974285653
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread