2020-02-27 02:49:16

by Kammela, Gayatri

[permalink] [raw]
Subject: [PATCH v1 0/4] platform/x86: intel_pmc_core: Add bug fixes or code

Hi,

This patch series consists of bug fixes and code optimization for the
series https://patchwork.kernel.org/patch/11365325/

Patch 1: Make pmc_core_lpm_display() generic
Patch 2: Relocate both pmc_core_slps0_display() and pmc_core_lpm_display()
Patch 3: Remove the duplicate if() condition to create debugfs entry
Patch 4: Add back slp_s0_offset attribute back to tgl_reg_map

Gayatri Kammela (4):
platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic
for platforms that support sub-states
platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display()
and pmc_core_lpm_display() to outside of CONFIG_DEBUG_FS
platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create
debugfs entry for substate_live_status_registers
platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to
tgl_reg_map

drivers/platform/x86/intel_pmc_core.c | 131 +++++++++++++-------------
1 file changed, 66 insertions(+), 65 deletions(-)

Cc: Chen Zhou <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: David Box <[email protected]>
--
2.17.1


2020-02-27 09:57:36

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH v1 0/4] platform/x86: intel_pmc_core: Add bug fixes or code

On Wed, Feb 26, 2020 at 06:43:26PM -0800, Gayatri Kammela wrote:
> Hi,
>
> This patch series consists of bug fixes and code optimization for the
> series https://patchwork.kernel.org/patch/11365325/
>
> Patch 1: Make pmc_core_lpm_display() generic
> Patch 2: Relocate both pmc_core_slps0_display() and pmc_core_lpm_display()
> Patch 3: Remove the duplicate if() condition to create debugfs entry
> Patch 4: Add back slp_s0_offset attribute back to tgl_reg_map

Let's do other way around, i.e. patch 2 as a first in the series, so I may fix
the current (visible) issue.

Then fix the kbuild bot complains and send the rest.

>
> Gayatri Kammela (4):
> platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic
> for platforms that support sub-states
> platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display()
> and pmc_core_lpm_display() to outside of CONFIG_DEBUG_FS
> platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create
> debugfs entry for substate_live_status_registers
> platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to
> tgl_reg_map
>
> drivers/platform/x86/intel_pmc_core.c | 131 +++++++++++++-------------
> 1 file changed, 66 insertions(+), 65 deletions(-)
>
> Cc: Chen Zhou <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: David Box <[email protected]>
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko


2020-02-27 15:53:54

by Kammela, Gayatri

[permalink] [raw]
Subject: RE: [PATCH v1 0/4] platform/x86: intel_pmc_core: Add bug fixes or code



> -----Original Message-----
> From: Andy Shevchenko <[email protected]>
> Sent: Thursday, February 27, 2020 1:57 AM
> To: Kammela, Gayatri <[email protected]>
> Cc: [email protected]; [email protected];
> Somayaji, Vishwanath <[email protected]>;
> [email protected]; Westerberg, Mika <[email protected]>;
> [email protected]; Prestopine, Charles D
> <[email protected]>; Chen Zhou <[email protected]>;
> Box, David E <[email protected]>
> Subject: Re: [PATCH v1 0/4] platform/x86: intel_pmc_core: Add bug fixes or
> code
>
> On Wed, Feb 26, 2020 at 06:43:26PM -0800, Gayatri Kammela wrote:
> > Hi,
> >
> > This patch series consists of bug fixes and code optimization for the
> > series https://patchwork.kernel.org/patch/11365325/
> >
> > Patch 1: Make pmc_core_lpm_display() generic Patch 2: Relocate both
> > pmc_core_slps0_display() and pmc_core_lpm_display() Patch 3: Remove
> > the duplicate if() condition to create debugfs entry Patch 4: Add back
> > slp_s0_offset attribute back to tgl_reg_map
>
> Let's do other way around, i.e. patch 2 as a first in the series, so I may fix the
> current (visible) issue.

Hi Andy, sure I will change the order and send the version 2

>
> Then fix the kbuild bot complains and send the rest.

Sure, I will do that. Thanks!

>
> >
> > Gayatri Kammela (4):
> > platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic
> > for platforms that support sub-states
> > platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display()
> > and pmc_core_lpm_display() to outside of CONFIG_DEBUG_FS
> > platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create
> > debugfs entry for substate_live_status_registers
> > platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to
> > tgl_reg_map
> >
> > drivers/platform/x86/intel_pmc_core.c | 131
> > +++++++++++++-------------
> > 1 file changed, 66 insertions(+), 65 deletions(-)
> >
> > Cc: Chen Zhou <[email protected]>
> > Cc: Andy Shevchenko <[email protected]>
> > Cc: David Box <[email protected]>
> > --
> > 2.17.1
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>