Changes in v2:
- Add missing argument to devm_kzalloc() call in quad8_probe().
- Remove superfluous 'err' variable from quad8_probe().
The IIO counter driver has been superseded by the Counter subsystem as
discussed in [1]. This patchset removes the IIO counter ABI code and
documentation.
A patch to remove the IIO counter ABI code from the stm32-lptimer-cnt
counter driver has been submitted to the list separately [2]; if you
would like me to combine it with this patchset, please let me know.
One final user of the IIO counter ABI code is still remaining for now:
drivers/iio/trigger/stm32-timer-trigger.c. Is this driver related to the
drivers/counter/stm32-timer-cnt.c driver? Can it be migrated to the
Counter subsystem ABI instead?
[1] https://lore.kernel.org/lkml/[email protected]/
[2] https://marc.info/?l=linux-arm-kernel&m=161192667926697
William Breathitt Gray (2):
counter: 104-quad-8: Remove IIO counter ABI
iio: Remove the IIO counter ABI documentation
Documentation/ABI/testing/sysfs-bus-iio | 40 --
.../testing/sysfs-bus-iio-counter-104-quad-8 | 133 ----
MAINTAINERS | 1 -
drivers/counter/104-quad-8.c | 653 ++----------------
drivers/counter/Kconfig | 2 +-
5 files changed, 65 insertions(+), 764 deletions(-)
delete mode 100644 Documentation/ABI/testing/sysfs-bus-iio-counter-104-quad-8
--
2.30.0
The IIO counter driver has been superseded by the Counter subsystem as
discussed in [1]. This patch removes the IIO counter ABI documentation.
[1] https://lore.kernel.org/lkml/[email protected]/
Cc: Fabrice Gasnier <[email protected]>
Cc: Benjamin Gaignard <[email protected]>
Signed-off-by: William Breathitt Gray <[email protected]>
---
Documentation/ABI/testing/sysfs-bus-iio | 40 -------------------------
1 file changed, 40 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index d957f5da5c04..c207484a86d0 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -1704,46 +1704,6 @@ Description:
Raw (unscaled no offset etc.) electric conductivity reading that
can be processed to siemens per meter.
-What: /sys/bus/iio/devices/iio:deviceX/in_countY_raw
-KernelVersion: 4.10
-Contact: [email protected]
-Description:
- This interface is deprecated; please use the Counter subsystem.
-
- Raw counter device counts from channel Y. For quadrature
- counters, multiplication by an available [Y]_scale results in
- the counts of a single quadrature signal phase from channel Y.
-
-What: /sys/bus/iio/devices/iio:deviceX/in_indexY_raw
-KernelVersion: 4.10
-Contact: [email protected]
-Description:
- This interface is deprecated; please use the Counter subsystem.
-
- Raw counter device index value from channel Y. This attribute
- provides an absolute positional reference (e.g. a pulse once per
- revolution) which may be used to home positional systems as
- required.
-
-What: /sys/bus/iio/devices/iio:deviceX/in_count_count_direction_available
-KernelVersion: 4.12
-Contact: [email protected]
-Description:
- This interface is deprecated; please use the Counter subsystem.
-
- A list of possible counting directions which are:
-
- - "up" : counter device is increasing.
- - "down": counter device is decreasing.
-
-What: /sys/bus/iio/devices/iio:deviceX/in_countY_count_direction
-KernelVersion: 4.12
-Contact: [email protected]
-Description:
- This interface is deprecated; please use the Counter subsystem.
-
- Raw counter device counters direction for channel Y.
-
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_label
What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_label
KernelVersion: 5.8
--
2.30.0
On Sat, 30 Jan 2021 11:37:02 +0900
William Breathitt Gray <[email protected]> wrote:
> Changes in v2:
> - Add missing argument to devm_kzalloc() call in quad8_probe().
> - Remove superfluous 'err' variable from quad8_probe().
>
> The IIO counter driver has been superseded by the Counter subsystem as
> discussed in [1]. This patchset removes the IIO counter ABI code and
> documentation.
>
> A patch to remove the IIO counter ABI code from the stm32-lptimer-cnt
> counter driver has been submitted to the list separately [2]; if you
> would like me to combine it with this patchset, please let me know.
No problem, I've already picked that one.
>
> One final user of the IIO counter ABI code is still remaining for now:
> drivers/iio/trigger/stm32-timer-trigger.c. Is this driver related to the
> drivers/counter/stm32-timer-cnt.c driver? Can it be migrated to the
> Counter subsystem ABI instead?
I'm going to guess that we could probably drop the iio_dev part of the
stm32-timer-trigger entirely, though I'm not totally sure so wouldn't be
confident doing it without someone having hardware to test. In particular
there may be some connections between whether the device is enabled and
the triggers working that isn't documented anywhere that I can spot.
Whilst that's still in place, I'm going to pick up patch 1 of this set, but
leave patch 2. The ABI is clearly marked deprecated so we shouldn't get
new users and we can pick up that patch hwen the stm32-timer-trigger has
been tidied up as well.
Applied patch 1. Thanks,
Jonathan
>
> [1] https://lore.kernel.org/lkml/[email protected]/
> [2] https://marc.info/?l=linux-arm-kernel&m=161192667926697
>
> William Breathitt Gray (2):
> counter: 104-quad-8: Remove IIO counter ABI
> iio: Remove the IIO counter ABI documentation
>
> Documentation/ABI/testing/sysfs-bus-iio | 40 --
> .../testing/sysfs-bus-iio-counter-104-quad-8 | 133 ----
> MAINTAINERS | 1 -
> drivers/counter/104-quad-8.c | 653 ++----------------
> drivers/counter/Kconfig | 2 +-
> 5 files changed, 65 insertions(+), 764 deletions(-)
> delete mode 100644 Documentation/ABI/testing/sysfs-bus-iio-counter-104-quad-8
>