2022-08-14 06:10:16

by Rebecca Mckeever

Subject: [PATCH 0/2] memblock tests: add command line help option and update obsolete comments

These patches add a help command line option to the help message and
update references to an obsolete build option in comments.

Rebecca Mckeever (2):
memblock tests: add command line help option
memblock tests: update reference to obsolete build option in comments

tools/testing/memblock/tests/common.c | 4 +++-
tools/testing/memblock/tests/common.h | 9 ++++++---
2 files changed, 9 insertions(+), 4 deletions(-)

--
2.25.1

2022-08-14 06:44:47

by Rebecca Mckeever

Subject: [PATCH 1/2] memblock tests: add command line help option

Add a help command line option to the help message. Add the help option
to the short and long options so it will be recognized as a valid
option.

Usage:
$ ./main -h

Or:
$ ./main --help

Reviewed-by: David Hildenbrand <[email protected]>
Signed-off-by: Rebecca Mckeever <[email protected]>
---
tools/testing/memblock/tests/common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/testing/memblock/tests/common.c b/tools/testing/memblock/tests/common.c
index e43b2676af81..76a8ad818f3a 100644
--- a/tools/testing/memblock/tests/common.c
+++ b/tools/testing/memblock/tests/common.c
@@ -14,14 +14,16 @@ static struct test_memory memory_block;
static const char __maybe_unused *prefixes[PREFIXES_MAX];
static int __maybe_unused nr_prefixes;

-static const char *short_opts = "mv";
+static const char *short_opts = "hmv";
static const struct option long_opts[] = {
+ {"help", 0, NULL, 'h'},
{"movable-node", 0, NULL, 'm'},
{"verbose", 0, NULL, 'v'},
{NULL, 0, NULL, 0}
};

static const char * const help_opts[] = {
+ "display this help message and exit",
"disallow allocations from regions marked as hotplugged\n\t\t\t"
"by simulating enabling the \"movable_node\" kernel\n\t\t\t"
"parameter",
--
2.25.1

2022-08-23 16:47:51

by Mike Rapoport

Subject: Re: [PATCH 0/2] memblock tests: add command line help option and update obsolete comments

On Sun, Aug 14, 2022 at 12:50:18AM -0500, Rebecca Mckeever wrote:
> These patches add a help command line option to the help message and
> update references to an obsolete build option in comments.
>
> Rebecca Mckeever (2):
> memblock tests: add command line help option
> memblock tests: update reference to obsolete build option in comments
>
> tools/testing/memblock/tests/common.c | 4 +++-
> tools/testing/memblock/tests/common.h | 9 ++++++---
> 2 files changed, 9 insertions(+), 4 deletions(-)

Applied, thanks!

--
Sincerely yours,
Mike.