2022-08-19 09:48:37

by Nam Cao

Subject: [PATCH 0/3] staging: rtl8723bs: remove useless files

Delete odm_NoiseMonitor.c and odm_NoiseMonitor.h because they are
useless. The first 2 commits are preparation, and the final commit is
actual removal.

Nam Cao (3):
staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor
staging: rtl8723bs: remove member noise_level from struct dm_odm_t
staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c

drivers/staging/rtl8723bs/hal/odm.h | 2 -
.../staging/rtl8723bs/hal/odm_NoiseMonitor.c | 130 ------------------
.../staging/rtl8723bs/hal/odm_NoiseMonitor.h | 39 ------
drivers/staging/rtl8723bs/hal/odm_precomp.h | 1 -
4 files changed, 172 deletions(-)
delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h

--
2.25.1

2022-08-19 09:50:29

by Hans de Goede

Subject: Re: [PATCH 0/3] staging: rtl8723bs: remove useless files

Hi,

On 8/19/22 11:35, Nam Cao wrote:
> Delete odm_NoiseMonitor.c and odm_NoiseMonitor.h because they are
> useless. The first 2 commits are preparation, and the final commit is
> actual removal.
>
> Nam Cao (3):
> staging: rtl8723bs: remove unused function ODM_InbandNoise_Monitor
> staging: rtl8723bs: remove member noise_level from struct dm_odm_t
> staging: rtl8723bs: remove odm_NoiseMonitor.h and odm_NoiseMonitor.c
>
> drivers/staging/rtl8723bs/hal/odm.h | 2 -
> .../staging/rtl8723bs/hal/odm_NoiseMonitor.c | 130 ------------------
> .../staging/rtl8723bs/hal/odm_NoiseMonitor.h | 39 ------
> drivers/staging/rtl8723bs/hal/odm_precomp.h | 1 -
> 4 files changed, 172 deletions(-)
> delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
> delete mode 100644 drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.h

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

for the series.

Regards,

Hans

2022-08-19 09:53:37

by Nam Cao

Subject: [PATCH 2/3] staging: rtl8723bs: remove member noise_level from struct dm_odm_t

because it is not used.

Signed-off-by: Nam Cao <[email protected]>
---
drivers/staging/rtl8723bs/hal/odm.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h
index 19cfc2915458..033f22b0f394 100644
--- a/drivers/staging/rtl8723bs/hal/odm.h
+++ b/drivers/staging/rtl8723bs/hal/odm.h
@@ -863,7 +863,6 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_Structure */
u8 Adaptivity_IGI_upper;
u8 NHM_cnt_0;

- struct odm_noise_monitor noise_level;/* ODM_MAX_CHANNEL_NUM]; */
/* */
/* 2 Define STA info. */
/* _ODM_STA_INFO */
--
2.25.1