2022-10-25 01:29:57

by Aaron Lawrence

Subject: [PATCH 0/5] staging: rtl8192e: rtllib_tx: code cleanup patches on the rtllib_tx.c file

Multiple patches regarding the cleanup of code in the rtllib_tx.c file.
Fixes were applied according to the report generated by the checkpatch
script on said file, aside from the CamelCase issues.

Aaron Lawrence (5):
Staging: rtl8192e: rtllib_tx: fixed multiple blank lines
Staging: rtl8192e: rtllib_tx: fixed alignment matching open
parenthesis
Staging: rtl8192e: rtllib_tx: added spaces around operators
Staging: rtl8192e: rtllib_tx: fixed lines ending with an open
parenthesis
Staging: rtl8192e: rtllib_tx: removed unnecessary blank line before a
close brace

drivers/staging/rtl8192e/rtllib_tx.c | 42 ++++++++++++----------------
1 file changed, 18 insertions(+), 24 deletions(-)

--
2.38.1

2022-10-25 01:54:00

by Aaron Lawrence

Subject: [PATCH 1/5] Staging: rtl8192e: rtllib_tx: fixed multiple blank lines

Multiple blank lines are condensed into a single blank line as per
the Linux kernel coding-style regulations. The issues were flagged
by the checkpatch script.

Signed-off-by: Aaron Lawrence <[email protected]>
---
drivers/staging/rtl8192e/rtllib_tx.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index e307020580a0..abb5b57d142b 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -191,7 +191,6 @@ int rtllib_encrypt_fragment(struct rtllib_device *ieee, struct sk_buff *frag,
return 0;
}

-
void rtllib_txb_free(struct rtllib_txb *txb)
{
if (unlikely(!txb))
@@ -475,7 +474,6 @@ static void rtllib_query_protectionmode(struct rtllib_device *ieee,
tcb_desc->bRTSBW = false;
}

-
static void rtllib_txrate_selectmode(struct rtllib_device *ieee,
struct cb_desc *tcb_desc)
{
@@ -582,7 +580,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
goto success;
}

-
if (likely(ieee->raw_tx == 0)) {
if (unlikely(skb->len < SNAP_SIZE + sizeof(u16))) {
netdev_warn(ieee->dev, "skb too small (%d).\n",
@@ -895,7 +892,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
tcb_desc->bTxDisableRateFallBack = 1;
}

-
tcb_desc->RATRIndex = 7;
tcb_desc->bTxUseDriverAssingedRate = 1;
} else {
@@ -920,7 +916,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
tcb_desc->bTxDisableRateFallBack = 1;
}

-
tcb_desc->RATRIndex = 7;
tcb_desc->bTxUseDriverAssingedRate = 1;
tcb_desc->bdhcp = 1;
--
2.38.1

2022-10-25 17:32:27

by Philipp Hortmann

Subject: Re: [PATCH 0/5] staging: rtl8192e: rtllib_tx: code cleanup patches on the rtllib_tx.c file

On 10/24/22 14:25, Aaron Lawrence wrote:
> Multiple patches regarding the cleanup of code in the rtllib_tx.c file.
> Fixes were applied according to the report generated by the checkpatch
> script on said file, aside from the CamelCase issues.
>
> Aaron Lawrence (5):
> Staging: rtl8192e: rtllib_tx: fixed multiple blank lines
> Staging: rtl8192e: rtllib_tx: fixed alignment matching open
> parenthesis
> Staging: rtl8192e: rtllib_tx: added spaces around operators
> Staging: rtl8192e: rtllib_tx: fixed lines ending with an open
> parenthesis
> Staging: rtl8192e: rtllib_tx: removed unnecessary blank line before a
> close brace
>
> drivers/staging/rtl8192e/rtllib_tx.c | 42 ++++++++++++----------------
> 1 file changed, 18 insertions(+), 24 deletions(-)
>

Tested-by: Philipp Hortmann <[email protected]>