2022-10-31 18:41:55

by Deepak R Varma

Subject: [PATCH v2 0/2] staging: rtl8192u: unused code cleanup

Remove unnecessary or unused code.

Changes in v2:
Patch1:
1. Revise patch log to explain impact of the patch
Suggested by [email protected]
Patch2:
1. Review other similar macro defines and clean those up as well.
Suggested by [email protected]
2. Revise patch log to explain impact of the patch
Suggested by [email protected]

Deepak R Varma (2):
staging: rtl8192u: remove unnecessary function implementation
staging: rtl8192u: remove redundant macro definition

.../staging/rtl8192u/ieee80211/ieee80211.h | 67 -------------------
.../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 --
.../rtl8192u/ieee80211/ieee80211_module.c | 3 -
3 files changed, 76 deletions(-)

--
2.30.2

2022-11-02 07:50:59

by Greg Kroah-Hartman

Subject: Re: [PATCH v2 0/2] staging: rtl8192u: unused code cleanup

On Mon, Oct 31, 2022 at 11:25:14PM +0530, Deepak R Varma wrote:
> Remove unnecessary or unused code.
>
> Changes in v2:
> Patch1:
> 1. Revise patch log to explain impact of the patch
> Suggested by [email protected]
> Patch2:
> 1. Review other similar macro defines and clean those up as well.
> Suggested by [email protected]
> 2. Revise patch log to explain impact of the patch
> Suggested by [email protected]
>
> Deepak R Varma (2):
> staging: rtl8192u: remove unnecessary function implementation
> staging: rtl8192u: remove redundant macro definition
>
> .../staging/rtl8192u/ieee80211/ieee80211.h | 67 -------------------
> .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 --
> .../rtl8192u/ieee80211/ieee80211_module.c | 3 -
> 3 files changed, 76 deletions(-)

This series causes a build breakage:

MODPOST Module.symvers
../ERROR: modpost: net/mac80211/mac80211: 'ieee80211_wake_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
ERROR: modpost: net/mac80211/mac80211: 'ieee80211_stop_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1
make: *** [Makefile:1944: modpost] Error 2

Always test build your changes.

greg k-h

2022-11-02 11:14:49

by Deepak R Varma

Subject: Re: [PATCH v2 0/2] staging: rtl8192u: unused code cleanup

On Wed, Nov 02, 2022 at 08:27:40AM +0100, Greg KH wrote:
> On Mon, Oct 31, 2022 at 11:25:14PM +0530, Deepak R Varma wrote:
> > Remove unnecessary or unused code.
> >
> > Changes in v2:
> > Patch1:
> > 1. Revise patch log to explain impact of the patch
> > Suggested by [email protected]
> > Patch2:
> > 1. Review other similar macro defines and clean those up as well.
> > Suggested by [email protected]
> > 2. Revise patch log to explain impact of the patch
> > Suggested by [email protected]
> >
> > Deepak R Varma (2):
> > staging: rtl8192u: remove unnecessary function implementation
> > staging: rtl8192u: remove redundant macro definition
> >
> > .../staging/rtl8192u/ieee80211/ieee80211.h | 67 -------------------
> > .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 6 --
> > .../rtl8192u/ieee80211/ieee80211_module.c | 3 -
> > 3 files changed, 76 deletions(-)
>
> This series causes a build breakage:
>
> MODPOST Module.symvers
> ../ERROR: modpost: net/mac80211/mac80211: 'ieee80211_wake_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
> ERROR: modpost: net/mac80211/mac80211: 'ieee80211_stop_queue' exported twice. Previous export was in drivers/staging/rtl8192u/r8192u_usb.ko
> make[1]: *** [scripts/Makefile.modpost:126: Module.symvers] Error 1
> make: *** [Makefile:1944: modpost] Error 2
>
> Always test build your changes.

My apologies. I did a limited driver specific build but did not run a full make.
I understand that the EXPORT_SYMBOL is across the kernel and I should have run a
full build.

I have made the corrections and now running a full build. I will send a revision
shortly.

Sorry for the trouble.

./drv



>
> greg k-h
>