Hi,
Jim Cromie hit a BUG() while toggling jump label branches in a module
before they were properly initialized. This isn't currently an issue,
but will be as part of his pending classmap series. Seems like we
should covert to using module callback notifier for dynamic debug
anyways. First patch is just a cleanup.
Link: https://lore.kernel.org/lkml/[email protected]/
Thanks,
-Jason
Jason Baron (2):
dyndbg: remove unused 'base' arg from __ddebug_add_module()
dyndbg: use the module notifier callbacks
include/linux/dynamic_debug.h | 13 ----------
include/linux/module.h | 3 +++
kernel/module/internal.h | 1 -
kernel/module/main.c | 30 ++++++---------------
lib/dynamic_debug.c | 49 ++++++++++++++++++++++++++++-------
5 files changed, 51 insertions(+), 45 deletions(-)
--
2.17.1
On Thu, Feb 16, 2023 at 10:16 AM Jason Baron <[email protected]> wrote:
>
> Hi,
>
> Jim Cromie hit a BUG() while toggling jump label branches in a module
> before they were properly initialized. This isn't currently an issue,
> but will be as part of his pending classmap series. Seems like we
> should covert to using module callback notifier for dynamic debug
> anyways. First patch is just a cleanup.
>
> Link: https://lore.kernel.org/lkml/[email protected]/
>
> Thanks,
>
> -Jason
>
> Jason Baron (2):
> dyndbg: remove unused 'base' arg from __ddebug_add_module()
> dyndbg: use the module notifier callbacks
Ive rebased my set upon yours, and dropped my RFC-workaround patch.
No panics on uninitialized jump-labels,
and test script works correctly.
Tested-by: Jim Cromie <[email protected]>
I will include your commits in my next send, so theyre testable as a set.
thanks
Jim
>
> include/linux/dynamic_debug.h | 13 ----------
> include/linux/module.h | 3 +++
> kernel/module/internal.h | 1 -
> kernel/module/main.c | 30 ++++++---------------
> lib/dynamic_debug.c | 49 ++++++++++++++++++++++++++++-------
> 5 files changed, 51 insertions(+), 45 deletions(-)
>
> --
> 2.17.1
>