2023-12-30 11:24:44

by Muhammed Efe Cetin

[permalink] [raw]
Subject: [PATCH v2 0/3] Add Support for NanoPi R6S and R6C boards

From: Muhammed Efe Cetin <[email protected]>

Hi, this series add support for RK3588S based NanoPi R6S and R6C boards.

Changes on v2:
* Add commit message to dt-bindings patch.
* Fix dtbs_check warnings.
* Rename vcc_3v3_s0 -> avcc_3v3_s0 and create new fixed vcc_3v3_s0 regulator.
* Rename vdd_ddr_pll_s0 -> avdd_ddr_pll_s0.
* Rename vdd_0v85_s0 -> avdd_0v85_s0.
* Fix rk806_dvs1_null and rk806_dvs2_null on pmic node.
* Add system-power-controller property to pmic node.

Muhammed Efe Cetin (3):
dt-bindings: arm: rockchip: Add NanoPi R6 series boards
arm64: dts: rockchip: Add support for NanoPi R6S
arm64: dts: rockchip: Add support for NanoPi R6C

.../devicetree/bindings/arm/rockchip.yaml | 7 +
arch/arm64/boot/dts/rockchip/Makefile | 2 +
.../boot/dts/rockchip/rk3588s-nanopi-r6c.dts | 14 +
.../boot/dts/rockchip/rk3588s-nanopi-r6s.dts | 764 ++++++++++++++++++
4 files changed, 787 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6c.dts
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6s.dts

--
2.43.0



2023-12-30 11:26:26

by Muhammed Efe Cetin

[permalink] [raw]
Subject: [PATCH v2 1/3] dt-bindings: arm: rockchip: Add NanoPi R6 series boards

From: Muhammed Efe Cetin <[email protected]>

Add support for NanoPi R6 series boards that based on RK3588S.

NanoPi R6S basically has:
- USB3
- USB2
- eMMC
- 2x 2.5GBe & 1x 1GBe ethernet
- HDMI
- SD card support

Unlike R6S variant, NanoPi R6C has PCIe M.2 M-key instead of 1x 2.5GBe.

Signed-off-by: Muhammed Efe Cetin <[email protected]>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index ee92f0535..07c4eb828 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -225,6 +225,13 @@ properties:
- friendlyarm,nanopi-r5s
- const: rockchip,rk3568

+ - description: FriendlyElec NanoPi R6 series boards
+ items:
+ - enum:
+ - friendlyarm,nanopi-r6c
+ - friendlyarm,nanopi-r6s
+ - const: rockchip,rk3588s
+
- description: FriendlyElec NanoPC T6
items:
- const: friendlyarm,nanopc-t6
--
2.43.0


2023-12-30 11:28:40

by Muhammed Efe Cetin

[permalink] [raw]
Subject: [PATCH v2 3/3] arm64: dts: rockchip: Add support for NanoPi R6C

From: Muhammed Efe Cetin <[email protected]>

NanoPi R6C is mostly same as R6S variant. It has M2 port instead of a
NIC port and different led labeling.

Signed-off-by: Muhammed Efe Cetin <[email protected]>
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../arm64/boot/dts/rockchip/rk3588s-nanopi-r6c.dts | 14 ++++++++++++++
2 files changed, 15 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6c.dts

diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 634b9be47..f2d13482e 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -115,3 +115,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-khadas-edge2.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6s.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6c.dts
new file mode 100644
index 000000000..497bbb570
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-r6c.dts
@@ -0,0 +1,14 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3588s-nanopi-r6s.dts"
+
+/ {
+ model = "FriendlyElec NanoPi R6C";
+ compatible = "friendlyarm,nanopi-r6c", "rockchip,rk3588s";
+};
+
+&lan2_led {
+ label = "user_led";
+};
--
2.43.0


2024-01-02 10:34:26

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/3] dt-bindings: arm: rockchip: Add NanoPi R6 series boards

On 30/12/2023 12:17, [email protected] wrote:
> From: Muhammed Efe Cetin <[email protected]>
>
> Add support for NanoPi R6 series boards that based on RK3588S.
>


Acked-by: Krzysztof Kozlowski <[email protected]>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof


2024-01-25 21:13:46

by Heiko Stübner

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] Add Support for NanoPi R6S and R6C boards

On Sat, 30 Dec 2023 14:17:58 +0300, [email protected] wrote:
> From: Muhammed Efe Cetin <[email protected]>
>
> Hi, this series add support for RK3588S based NanoPi R6S and R6C boards.
>
> Changes on v2:
> * Add commit message to dt-bindings patch.
> * Fix dtbs_check warnings.
> * Rename vcc_3v3_s0 -> avcc_3v3_s0 and create new fixed vcc_3v3_s0 regulator.
> * Rename vdd_ddr_pll_s0 -> avdd_ddr_pll_s0.
> * Rename vdd_0v85_s0 -> avdd_0v85_s0.
> * Fix rk806_dvs1_null and rk806_dvs2_null on pmic node.
> * Add system-power-controller property to pmic node.
>
> [...]

Applied, thanks!

[1/3] dt-bindings: arm: rockchip: Add NanoPi R6 series boards
commit: 2eaa5e73f51ff5abce18d58f6d0635880df1b8d0
[2/3] arm64: dts: rockchip: Add support for NanoPi R6S
commit: f1b11f43b3e983b26d8010fc43ba6c2b979826f2
[3/3] arm64: dts: rockchip: Add support for NanoPi R6C
commit: d5f1d7437451dbd86a91747793ecd7842e0ce88f

Best regards,
--
Heiko Stuebner <[email protected]>