2023-09-22 18:17:47

by Jeongtae Park

Subject: [PATCH v2 4/7] cxl: Fix a checkpatch error

ERROR: Macros with complex values should be enclosed in parentheses

Signed-off-by: Jeongtae Park <[email protected]>
Reviewed-by: Dave Jiang <[email protected]>
---
drivers/cxl/cxl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
index 76d92561af29..545381355efb 100644
--- a/drivers/cxl/cxl.h
+++ b/drivers/cxl/cxl.h
@@ -142,7 +142,7 @@ static inline int ways_to_eiw(unsigned int ways, u8 *eiw)
#define CXL_RAS_HEADER_LOG_OFFSET 0x18
#define CXL_RAS_CAPABILITY_LENGTH 0x58
#define CXL_HEADERLOG_SIZE SZ_512
-#define CXL_HEADERLOG_SIZE_U32 SZ_512 / sizeof(u32)
+#define CXL_HEADERLOG_SIZE_U32 (SZ_512 / sizeof(u32))

/* CXL 2.0 8.2.8.1 Device Capabilities Array Register */
#define CXLDEV_CAP_ARRAY_OFFSET 0x0
--
2.34.1

2023-09-28 12:13:48

by Davidlohr Bueso

Subject: Re: [PATCH v2 4/7] cxl: Fix a checkpatch error

On Fri, 22 Sep 2023, Jeongtae Park wrote:

>ERROR: Macros with complex values should be enclosed in parentheses
>
>Signed-off-by: Jeongtae Park <[email protected]>
>Reviewed-by: Dave Jiang <[email protected]>

Reviewed-by: Davidlohr Bueso <[email protected]>

>---
> drivers/cxl/cxl.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
>index 76d92561af29..545381355efb 100644
>--- a/drivers/cxl/cxl.h
>+++ b/drivers/cxl/cxl.h
>@@ -142,7 +142,7 @@ static inline int ways_to_eiw(unsigned int ways, u8 *eiw)
> #define CXL_RAS_HEADER_LOG_OFFSET 0x18
> #define CXL_RAS_CAPABILITY_LENGTH 0x58
> #define CXL_HEADERLOG_SIZE SZ_512
>-#define CXL_HEADERLOG_SIZE_U32 SZ_512 / sizeof(u32)
>+#define CXL_HEADERLOG_SIZE_U32 (SZ_512 / sizeof(u32))
>
> /* CXL 2.0 8.2.8.1 Device Capabilities Array Register */
> #define CXLDEV_CAP_ARRAY_OFFSET 0x0
>--
>2.34.1
>