2021-06-09 08:52:07

by Christophe Leroy

Subject: [PATCH] powerpc/32: Remove __main()

Comment says that __main() is there to make GCC happy.

It's been there since the implementation of ppc arch in Linux 1.3.45.

ppc32 is the only architecture having that. Even ppc64 doesn't have it.

Seems like GCC is still happy without it.

Drop it for good.

Signed-off-by: Christophe Leroy <[email protected]>
---
arch/powerpc/kernel/misc_32.S | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S
index 6a076bef2932..39ab15419592 100644
--- a/arch/powerpc/kernel/misc_32.S
+++ b/arch/powerpc/kernel/misc_32.S
@@ -388,9 +388,3 @@ _GLOBAL(start_secondary_resume)
bl start_secondary
b .
#endif /* CONFIG_SMP */
-
-/*
- * This routine is just here to keep GCC happy - sigh...
- */
-_GLOBAL(__main)
- blr
--
2.25.0

2021-06-18 06:20:42

by Michael Ellerman

Subject: Re: [PATCH] powerpc/32: Remove __main()

On Tue, 8 Jun 2021 17:22:51 +0000 (UTC), Christophe Leroy wrote:
> Comment says that __main() is there to make GCC happy.
>
> It's been there since the implementation of ppc arch in Linux 1.3.45.
>
> ppc32 is the only architecture having that. Even ppc64 doesn't have it.
>
> Seems like GCC is still happy without it.
>
> [...]

Applied to powerpc/next.

[1/1] powerpc/32: Remove __main()
https://git.kernel.org/powerpc/c/4696cfdb1380238dca2bda6199428d7e50c4ea38

cheers