2016-10-26 14:30:05

by Felix Brack

Subject: [PATCH] led: pca9532: Use default trigger value from platform data

The value for a led's default_trigger should come from platform data
instead of data (which is always 0).

Signed-off-by: Felix Brack <[email protected]>
---

diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
index 09a7cffb..06e6310 100644
--- a/drivers/leds/leds-pca9532.c
+++ b/drivers/leds/leds-pca9532.c
@@ -369,7 +369,7 @@ static int pca9532_configure(struct i2c_client *client,
led->state = pled->state;
led->name = pled->name;
led->ldev.name = led->name;
- led->ldev.default_trigger = led->default_trigger;
+ led->ldev.default_trigger = pled->default_trigger;
led->ldev.brightness = LED_OFF;
led->ldev.brightness_set_blocking =
pca9532_set_brightness;

2016-10-26 14:45:23

by Jacek Anaszewski

Subject: Re: [PATCH] led: pca9532: Use default trigger value from platform data

Hi Felix,

Thanks for the patch. Applied.

On 10/26/2016 04:08 PM, Felix Brack wrote:
> The value for a led's default_trigger should come from platform data
> instead of data (which is always 0).
>
> Signed-off-by: Felix Brack <[email protected]>
> ---
>
> diff --git a/drivers/leds/leds-pca9532.c b/drivers/leds/leds-pca9532.c
> index 09a7cffb..06e6310 100644
> --- a/drivers/leds/leds-pca9532.c
> +++ b/drivers/leds/leds-pca9532.c
> @@ -369,7 +369,7 @@ static int pca9532_configure(struct i2c_client *client,
> led->state = pled->state;
> led->name = pled->name;
> led->ldev.name = led->name;
> - led->ldev.default_trigger = led->default_trigger;
> + led->ldev.default_trigger = pled->default_trigger;
> led->ldev.brightness = LED_OFF;
> led->ldev.brightness_set_blocking =
> pca9532_set_brightness;
>
>
>


--
Best regards,
Jacek Anaszewski