2022-10-31 03:35:46

by Rex-BC Chen (陳柏辰)

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bingings: gce: add gce header file for mt8188

On Sat, 2022-10-29 at 18:50 +0800, Elvis.Wang wrote:
> From: Elvis Wang <[email protected]>
>
> add gce header file to define the gce thread priority, gce subsys id,
> event and constant for mt8188.
> v2 - use vendor in filename, use Dual license.
>
> Signed-off-by: Elvis Wang <[email protected]>
> Reviewed-by: Bo-Chen Chen <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> Thanks for the reviews, I have fixed them.
>
Hello Elvis,

I think Krzysztof and I don't give you our "Reviewed-by" tag.
This tag shows that we accept you patch but we don't accept your patch.

You can add this tag if you see someone leave something like this:
"Reviewed-by: Bo-Chen Chen <[email protected]>" and then you can
add it to your patch.

Please remove them.

Please read this:



https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

BRs,
Bo-Chen


2022-11-02 10:27:54

by Elvis Wang (王军)

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bingings: gce: add gce header file for mt8188

On Mon, 2022-10-31 at 03:04 +0000, Rex-BC Chen (陳柏辰) wrote:
> On Sat, 2022-10-29 at 18:50 +0800, Elvis.Wang wrote:
> > From: Elvis Wang <[email protected]>
> >
> > add gce header file to define the gce thread priority, gce subsys
> > id,
> > event and constant for mt8188.
> > v2 - use vendor in filename, use Dual license.
> >
> > Signed-off-by: Elvis Wang <[email protected]>
> > Reviewed-by: Bo-Chen Chen <[email protected]>
> > Reviewed-by: Krzysztof Kozlowski <[email protected]>
> >
> > Thanks for the reviews, I have fixed them.
> >
>
> Hello Elvis,
>
> I think Krzysztof and I don't give you our "Reviewed-by" tag.
> This tag shows that we accept you patch but we don't accept your
> patch.
>
> You can add this tag if you see someone leave something like this:
> "Reviewed-by: Bo-Chen Chen <[email protected]>" and then you
> can
> add it to your patch.
>
> Please remove them.
>
> Please read this:
>
Hi Bo-Chen,

Sorry for the later reply, there is something wrong with the mail
system.
Regarding the "Reviewd-by" in the message, my previous understanding
was wrong. I understand is who reviewed it not accepted it.
Sorry for the unnecessary misunderstanding, I will delete it in the
next version, thanks.
>
>
>
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
>
> BRs,
> Bo-Chen