2024-03-06 05:23:23

by Chaitanya Kulkarni

[permalink] [raw]
Subject: Re: [PATCH 1/3] nvme: core: constify struct class usage

On 3/5/24 05:15, Ricardo B. Marliere wrote:
> Since commit 43a7206b0963 ("driver core: class: make class_register() take
> a const *"), the driver core allows for struct class to be in read-only
> memory, so move the structures nvme_class, nvme_subsys_class and
> nvme_ns_chr_class to be declared at build time placing them into read-only
> memory, instead of having to be dynamically allocated at boot time.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
> ---
>

Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

-ck